Compute ImageCacheKey's hash number lazily

RESOLVED FIXED in Firefox 67

Status

()

enhancement
P3
normal
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
mozilla67
Points:
---

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

4 months ago

In bug 1516540 it has become obvious that ImageCacheKey::GetSpecialCaseDocumentToken()
can be expensive to call. Right now that function is being called
unconditionally from the constructor. This patch changes things
so that the hash number computation which requires calling that
function happens lazily when needed, so in case nothing requires
reading the hash number from the image cache key, that computation
can be skipped.

Priority: -- → P3

Comment 2

4 months ago
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/045d790ca417
Compute ImageCacheKey's hash number lazily; r=tnikkel

Comment 3

4 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.