[pyconfigure] Improvements related to imply_option

RESOLVED FIXED in Firefox 67

Status

enhancement
RESOLVED FIXED
5 months ago
18 days ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

(Blocks 1 bug)

unspecified
mozilla67
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(2 attachments)

No description provided.

I thought I had two improvements, but it turns out the first one addresses both usecases.

Summary: [pyconfigure] Improvements related to imply_option → [pyconfigure] Handle dependency loops involving imply_option more gracefully

Actually no, I still have two.

Summary: [pyconfigure] Handle dependency loops involving imply_option more gracefully → [pyconfigure] Improvements related to imply_option

Currently, when a dependency loop involve imply_option, it is possible
to end up with an error message saying the implied option is unknown,
when it fact it is. So instead of bailing out with a weird error
message, try to make things work (if the implied value is not different
from what's known), or bail with a more accurate message.

In cases like those in the added unit test, explicit options on the
command line could end up being silently ignored. So instead of that happening,
error out. Unfortunately, the error message is not entirely accurate,
but it's better than nothing. It's rare anyways (I only stumbled upon it
because I was trying to do something fishy), and correlation between the
error message and the corresponding changes should make it clear what's
going on.

Depends on D20822

Blocks: 1530562
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/9d7e38697dee
Handle dependency loops involving imply_option more gracefully. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/69f758a41070
Prevent recursive resolution of options during imply_option. r=chmanchester
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Blocks: 1563158
You need to log in before you can comment on or make changes to this bug.