1529816 - Remove listening code from socket.jsm

Status: RESOLVED FIXED

(Chat Core :: General, enhancement)

Description

[Patrick Cloke [:clokep]]

Since the JavaScript socket code was added (in bug 954108) it had support for listening for incoming connections... I'm pretty sure this was implemented "just because I could" (I think it was actually implemented so I could test the client socket code against something). Anyway, no protocols act as a server (and it doesn't even really make sense). It is unnecessary and is dead-weight. We should remove support for this!

Comment 1

[Patrick Cloke [:clokep]]

Attachment: Server socket removal

I tested this by connection both XMPP and IRC accounts.

Comment 2

[Florian Quèze [:florian]]

Comment on attachment 9045824 [details] [diff] [review]
Server socket removal

Review of attachment 9045824 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, no point in keeping around code that is neither used nor covered by tests. I think we thought this was going to be needed to implement file transfert support, but I don't see us working on file transfer in the near future.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e969a8ddae1b
Remove listening code from socket.jsm. r=florian