Closed
Bug 1529816
Opened 5 years ago
Closed 5 years ago
Remove listening code from socket.jsm
Categories
(Chat Core :: General, enhancement)
Chat Core
General
Tracking
(Not tracked)
RESOLVED
FIXED
Instantbird 67
People
(Reporter: clokep, Assigned: clokep)
Details
Attachments
(1 file)
4.20 KB,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
Since the JavaScript socket code was added (in bug 954108) it had support for listening for incoming connections... I'm pretty sure this was implemented "just because I could" (I think it was actually implemented so I could test the client socket code against something). Anyway, no protocols act as a server (and it doesn't even really make sense). It is unnecessary and is dead-weight. We should remove support for this!
Assignee | ||
Comment 1•5 years ago
|
||
I tested this by connection both XMPP and IRC accounts.
Attachment #9045824 -
Flags: review?(florian)
Comment 2•5 years ago
|
||
Comment on attachment 9045824 [details] [diff] [review] Server socket removal Review of attachment 9045824 [details] [diff] [review]: ----------------------------------------------------------------- Yeah, no point in keeping around code that is neither used nor covered by tests. I think we thought this was going to be needed to implement file transfert support, but I don't see us working on file transfer in the near future.
Attachment #9045824 -
Flags: review?(florian) → review+
Pushed by clokep@gmail.com:
https://hg.mozilla.org/comm-central/rev/e969a8ddae1b
Remove listening code from socket.jsm. r=florian
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•5 years ago
|
Target Milestone: --- → Instantbird 67
You need to log in
before you can comment on or make changes to this bug.
Description
•