1529856 - For the displayed message source of and email using https://outlook.live.com, the text select is malfunctioning.

Status: RESOLVED WORKSFORME

(Core :: DOM: Selection, defect, P2)

Description

[TezzerFX]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0

Steps to reproduce:

Using https://outlook.live.com online email, display an email, under more actions select "View message source". In the message source frame attempt to select a section of text.

Actual results:

From the selection start point (left mouse button held down) all text gets instantly selected up to the end of the message source. Further on right mouse button held down, the copy drop down doesn't appear and the selection is cleared, instead the
page action drop down appears. Double left mouse click can sometimes followed by a selection attempt sporadically work, or may only select whole portions of text, and the copy options are still unavailable!

Expected results:

Normal text selection with copy options should occur in the message source frame as it does for any email or any copy-able html page! This problem seems to have arisen since 65.0.1. Also note: this is not an issue with the last ESR versions of firefox or the last version of Cyberfox.

Comment 1

[Gingerbread Man]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0
20190211233335

I haven't tested ESR but in Vivaldi it's not possible to select anything by clicking and dragging. So this may end up moved to Web Compatibility :: Desktop.

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

I tried versions back to 59; the issue can be reproduced on all the previous versions. HOWEVER, this issue is reproducible on chrome, too. So I think I'd agree with comment 1 that this could be a website issue. This doesn't look a regression to me.

Dear reporter, could you please confirm this is a regression and get the regression window for us by running mozregression tool [1]?

[1] https://github.com/mozilla/mozregression/releases

Comment 3

[TezzerFX]

The drag select and the "right mouse button" drop-down copy option menu, work perfectly on the message source, as expected, for
Firefox 52.9.0 32-bit (Vista 64-bit OS) and for Cyberfox 52.9.1 64-bit (W10 1809 OS build 17763.316 64-bit OS) which is based on Firefox 52.9. I think these were last publicly available ESR Firefox versions. So it seems to me this is not explicitly a "website" issue for just any or at least not all browsers. As to Firefox 65.0.1 (64-bit), you tell me!

In order to copy sections of the "message source" to the clipboard, Cyberfox 52.9.1 64-bit has to be used which may have security issues. These Firefox 52.9 versions are the only prior versions available on systems here for testing. Thus it seems this is undoubtedly a Firefox 65.0.1 (64-bit) issue! Unfortunately running the mozregression tool will not be possible, hence as to versions prior to 65.0.1 and after 52.9, someone with the appropriate capabilities will have to perform any regression tests.

Comment 4

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

[Regression range]:

Last good: build id = 20171215220126
First bad: build id = 20171216220320

Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4398768baa23a1d1888116a484817e20f2701dcc&tochange=29c2618abb00fdc3358e43902c899f9bd20005b7

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Regression from 2017, I don't think I need to track this for 66.
Maybe we can aim for a fix in 68 or 67.
Hsin-Yi, can you find someone to investigate?

Comment 6

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Masayuki,can you please help look at the regression window in comment 4 and suggest which looks suspicious? Thank you.

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Bug 1424633 or bug 1424839 might be related.

Looks like that outlook touches styles and stops propagation of events at focus, blur and mousedown. That might cause canceling selection on Chrome and changing start point of Firefox.

Comment 8

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Thanks Masayuki!
Hi Emilio and Adam, could you please take a look?

Comment 9

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

This doesn't seem to be affected by backing out bug 1424839.

Backing out bug 1424633 does seem to fix it, but I'll leave it to Emilio as I don't know this code well.

Comment 10

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

Attachment: Backout 1424633 (bad export)

I'm not suggesting this as a fix, but here's the backout patch that I ended up with, for comparison.

Comment 11

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

Attachment: Backout 1424633 (for convenience only)

Comment 12

[Emilio Cobos Álvarez (:emilio)]

The page looks like (oversimplified):

<div tabindex=-1 ...>
  <div style="position: fixed">
    ... Contents ...
  </div>
</div>

So before my patch we wouldn't focus the <div tabindex=-1> when clicking inside the contents, but after my patch we do.

Blink does something really weird. If the <div> is empty (apart from out of flow children), then it refuses to make it focusable.

<!doctype html>
<html lang="en">
<div tabindex="-1">
  <div style="position: fixed">
    Fixed
  </div>
</div>

But as long as it has contents, Blink makes it focusable just like us:

<!doctype html>
<html lang="en">
<div tabindex="-1">
  In flow
  <div style="position: fixed">
    Fixed
  </div>
</div>

I think their behavior here is completely inconsistent. Also, WebKit matches us here.

I don't really think aligning with Blink is the right thing to do here... Can we reach out to the Outlook folks rather than doing that?

Comment 13

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

I'll forward a reference to this to the Mozilla/Microsoft discussion list.

Comment 14

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Thanks Emilio and Adam!

Comment 15

[Neha Kochar [:neha]]

Adam, any updates from the outlook team?

Comment 16

[TezzerFX]

Since I reported this bug, over the last week something has changed after the 66.0.1 update, namely the drag select and right mouse copy etc. options seem to be fully functioning as expected!

What Happened???

Comment 17

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

(In reply to Neha Kochar [:neha] from comment #15)

Adam, any updates from the outlook team?

Some Microsoft folks took a look at it and opened a bug on their end March 6, but that was the last I heard of it. I haven't checked personally but from TezzerFX's comment 16 it sounds like it's been fixed.

Comment 18

[Neha Kochar [:neha]]

(In reply to TezzerFX from comment #16)

Since I reported this bug, over the last week something has changed after the 66.0.1 update, namely the drag select and right mouse copy etc. options seem to be fully functioning as expected!

What Happened???

Maybe Microsoft fixed it then (my best guess).

Comment 19

[Neha Kochar [:neha]]

Closing the bug as resolved per comment 16.