Remove the 2 from speculate speculative(Anonymous)Connect2 within nsISpeculativeConnect.idl

RESOLVED FIXED in Firefox 67

Status

()

enhancement
P2
normal
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: ckerschb, Assigned: ckerschb)

Tracking

unspecified
mozilla67
Points:
---

Firefox Tracking Flags

(firefox67 fixed)

Details

(Whiteboard: [domsecurity-active])

Attachments

(1 attachment)

Now that we are done with our Security By Default Project we can remove the 2 from the various interfaces.

Assignee

Updated

4 months ago
Assignee: nobody → ckerschb
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [domsecurity-active]
Assignee

Updated

4 months ago
Keywords: checkin-needed

The patch failed to apply:

hg error in cmd: hg push -r tip upstream: pushing to ssh://hg.mozilla.org/integration/autoland searching for changes remote: adding changesets remote: adding manifests remote: adding file changes remote: added 1 changesets with 15 changes to 15 files remote: remote: remote: ************************** ERROR **************************** remote: Rev 0c4bb7dab475 needs "Bug N" or "No bug" in the commit message. remote: Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> remote: Summary: r=valentin remote: Bug 1529869: Remove the 2 from speculate speculative(Anonymous)Connect2 within nsISpeculativeConnect.idl. r=valentin remote: remote: Differential Revision: https://phabricator.services.mozilla.com/D20949 remote: ************************************************************* remote: remote: remote: transaction abort! remote: rollback completed remote: pretxnchangegroup.c_commitmessage hook failed abort: push failed on remote -

Flags: needinfo?(ckerschb)
Keywords: checkin-needed

(In reply to Raul Gurzau (:RaulGurzau) from comment #2)

The patch failed to apply:

hg error in cmd: hg push -r tip upstream: pushing to ssh://hg.mozilla.org/integration/autoland searching for changes remote: adding changesets remote: adding manifests remote: adding file changes remote: added 1 changesets with 15 changes to 15 files remote: remote: remote: ************************** ERROR **************************** remote: Rev 0c4bb7dab475 needs "Bug N" or "No bug" in the commit message. remote: Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> remote: Summary: r=valentin remote: Bug 1529869: Remove the 2 from speculate speculative(Anonymous)Connect2 within nsISpeculativeConnect.idl. r=valentin remote: remote: Differential Revision: https://phabricator.services.mozilla.com/D20949 remote: ************************************************************* remote: remote: remote: transaction abort! remote: rollback completed remote: pretxnchangegroup.c_commitmessage hook failed abort: push failed on remote -

This happened to me before and I don't know why. Isn't that the summary that is generated from 'arc diff'? Confuses me.

Flags: needinfo?(ckerschb)

Comment 4

4 months ago
Pushed by mozilla@christophkerschbaumer.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d2599501754a
Remove the 2 from speculate speculative(Anonymous)Connect2 within nsISpeculativeConnect.idl. r=valentin
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.