Private Browsing assets are barely visible
Categories
(Firefox for iOS :: General, defect, P2)
Tracking
()
People
(Reporter: SimonB, Assigned: garvan)
References
Details
Attachments
(1 file)
166.81 KB,
image/png
|
Details |
Build: 50bfc36643
Device: iPhone XR
iOS: 12.0
Preconditions:
- Go to Settings -> Display and select "Dark Theme"
Steps to reproduce:
- Open Tabs Tray
- Go to Private Browsing
Actual results:
- The mask icon is barley visible and smaller.
Expected results:
- In previous builds the mask icon was larger and had a grey color in Dark Theme.
Updated•6 years ago
|
Comment 1•6 years ago
|
||
I would like to work on this issue if you don't mind.
Comment 2•6 years ago
|
||
(In reply to Volodymyr Klymenko from comment #1)
I would like to work on this issue if you don't mind.
Sure! Here's what the old image asset looked like:
You'll essentially have to apply a tint color to the new version of the mask icon asset.
Updated•6 years ago
|
Comment 3•6 years ago
|
||
I'm fairly certain that the color that needs to be applied to this icon is "Grey60":
https://github.com/mozilla-mobile/firefox-ios/pull/4591
Sorry I didn't see this was assigned already. It was bugging me so I went ahead a did a patch for it.
Comment 5•6 years ago
|
||
Landed on master:
https://github.com/mozilla-mobile/firefox-ios/commit/12586a865e5ec545c5aec19212d4b379fb914d80
Description
•