Closed Bug 1529876 Opened 6 years ago Closed 6 years ago

Private Browsing assets are barely visible

Categories

(Firefox for iOS :: General, defect, P2)

Other
iOS
defect

Tracking

()

VERIFIED FIXED
Tracking Status
fxios 16.0 ---
fxios-v16.0 --- verified

People

(Reporter: SimonB, Assigned: garvan)

References

Details

Attachments

(1 file)

Build: 50bfc36643
Device: iPhone XR
iOS: 12.0

Preconditions:

  • Go to Settings -> Display and select "Dark Theme"

Steps to reproduce:

  1. Open Tabs Tray
  2. Go to Private Browsing

Actual results:

  • The mask icon is barley visible and smaller.

Expected results:

  • In previous builds the mask icon was larger and had a grey color in Dark Theme.
Priority: -- → P2

I would like to work on this issue if you don't mind.

(In reply to Volodymyr Klymenko from comment #1)

I would like to work on this issue if you don't mind.

Sure! Here's what the old image asset looked like:

https://github.com/mozilla-mobile/firefox-ios/blob/15d5f298df072efe74fb456bc2cfd682ffc70422/Client/Assets/Images.xcassets/largePrivateMask.imageset/largePrivateMask.pdf

You'll essentially have to apply a tint color to the new version of the mask icon asset.

Flags: needinfo?(klymenkodp)
Assignee: nobody → klymenkodp
Status: NEW → ASSIGNED

https://github.com/mozilla-mobile/firefox-ios/pull/4591

Sorry I didn't see this was assigned already. It was bugging me so I went ahead a did a patch for it.

Flags: needinfo?(klymenkodp)
Assignee: klymenkodp → gkeeley
Summary: Private Browsing assets are barley visible → Private Browsing assets are barely visible
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED

Verifying as fix on 16.0(14386).

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: