Closed Bug 1529939 Opened 2 years ago Closed 2 years ago

Remove JSVAL_TYPE_MISSING

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: evilpie, Assigned: evilpie)

Details

Attachments

(1 file)

This type is apparently only used for one specific case in Codegen.py. However we don't test for it anywhere, so I think we can just replace it with JSVAL_TYPE_UNKNOWN.

I have no idea why that chunk of codegen is using JSVAL_TYPE_MISSING... And yes, I know I wrote that code.

The methods involved always return a Promise, so we should be able to use JSVAL_TYPE_OBJECT here, I would think.

Assignee: nobody → evilpies

Mhm. I am curious if we even use the type in that specific case, otherwise I would assume we would actually run into asserts with JSVAL_TYPE_MISSING.

At the moment, we do not, I believe.

Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/805264e071d9
Remove JSVAL_TYPE_MISSING. r=bzbarsky,jandem
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.