Remove JSVAL_TYPE_MISSING

RESOLVED FIXED in Firefox 67

Status

()

enhancement
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: evilpie, Assigned: evilpie)

Tracking

unspecified
mozilla67
Points:
---

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

3 months ago

This type is apparently only used for one specific case in Codegen.py. However we don't test for it anywhere, so I think we can just replace it with JSVAL_TYPE_UNKNOWN.

I have no idea why that chunk of codegen is using JSVAL_TYPE_MISSING... And yes, I know I wrote that code.

The methods involved always return a Promise, so we should be able to use JSVAL_TYPE_OBJECT here, I would think.

Assignee

Updated

3 months ago
Assignee: nobody → evilpies
Assignee

Comment 2

3 months ago

Mhm. I am curious if we even use the type in that specific case, otherwise I would assume we would actually run into asserts with JSVAL_TYPE_MISSING.

At the moment, we do not, I believe.

Comment 5

3 months ago
Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/805264e071d9
Remove JSVAL_TYPE_MISSING. r=bzbarsky,jandem

Comment 6

3 months ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.