tweak how ExternalHelperAppParent gets load info from ContentParent

RESOLVED FIXED in Firefox 67

Status

()

enhancement
P2
normal
RESOLVED FIXED
4 months ago
3 months ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

(Blocks 1 bug)

unspecified
mozilla67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(3 attachments)

This is helpful in the refactoring required by bug 1521120 to consume
LoadInfo/Principal/CSP/etc. arguments by move rather than by copy.

Alloc methods can't take arguments by move reference, whereas Recv
methods can, and we'd like to take OptionalLoadInfoArgs (at least) by
move reference.  Since Init is infallible anyway, it doesn't really
matter where we do it, so move it to this separate method to pave the
way for rvalue reference OptionalLoadInfoArgs.
Attachment #9045971 - Flags: review?(kyle)
Init is called from a Recv* method in ContentParent, where we can
consume rvalue reference OptionalLoadInfoArgs.

This is not perfect; it would be more ideal if IPDL gave us the concrete
ExternalHelperAppParent pointer rather than PExternalHelperAppParent, but that
is a separate bit of work.
Attachment #9045972 - Flags: review?(kyle)
Attachment #9045970 - Flags: review?(kyle) → review+
Attachment #9045971 - Flags: review?(kyle) → review+
Attachment #9045972 - Flags: review?(kyle) → review+
Priority: -- → P2

Comment 4

4 months ago
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a0429623a0a5
part 0 - remove unused ContentParent argument from ExternalHelperAppParent::Init; r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/c67d5054674e
part 1 - move initialization of ExternalHelperAppParent into Recv*; r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/49b2a4c8be01
part 2 - move OptionalLoadInfoArgs consumption into Init; r=qdot
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.