1529959 - memory leaks in atob/btoa

Status: RESOLVED FIXED

(NSS :: Tools, defect)

Description

[Kai Engert (:KaiE:)]

The NSS helper tools atob and btoa don't destroy the optstate.
I saw that in the try build for bug 1529950

https://treeherder.mozilla.org/#/jobs?repo=nss-try&revision=d002f0ca2da88fbef464505ef17e59657f28c2bc

Comment 1

[Kai Engert (:KaiE:)]

Attachment: 1529959-v1.patch

Comment 2

[J.C. Jones [:jcj] (he/him)]

Comment on attachment 9045990 [details] [diff] [review]
1529959-v1.patch

Review of attachment 9045990 [details] [diff] [review]:
-----------------------------------------------------------------

For all the early returns, let's destroy the opstate too, and then we won't have to worry about touching these again for a while. :)

::: cmd/atob/atob.c
@@ +145,4 @@
>                  if (!outFile) {
>                      fprintf(stderr, "%s: unable to open \"%s\" for writing\n",
>                              progName, optstate->value);
>                      return -1;

note we'll still leak for all the early returns

Comment 3

[J.C. Jones [:jcj] (he/him)]

(note, both utils)

Comment 4

[Kai Engert (:KaiE:)]

Attachment: 1529959-v2.patch

You're right, we should cleanup completley, but that made the patch much bigger...

Comment 5

[J.C. Jones [:jcj] (he/him)]

Comment on attachment 9046119 [details] [diff] [review]
1529959-v2.patch

Review of attachment 9046119 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, Kai.

Comment 6

[Kai Engert (:KaiE:)]

https://hg.mozilla.org/projects/nss/rev/56f95e1e0c26