GV API to toggle CSS prefers-color-scheme media query (aka CSS Dark Mode)

RESOLVED FIXED in Firefox 68

Status

enhancement
P1
normal
RESOLVED FIXED
2 months ago
17 days ago

People

(Reporter: cpeterson, Assigned: mbrubeck)

Tracking

unspecified
mozilla68
All
Android
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr60 wontfix, firefox65 wontfix, firefox66 wontfix, firefox67 wontfix, firefox68 fixed)

Details

(Whiteboard: [geckoview:fenix:m3], URL)

Attachments

(1 attachment)

(Reporter)

Description

2 months ago

Fenix feature request:
https://github.com/mozilla-mobile/fenix/issues/627

Stefan says we may need an A-C issue.

(Reporter)

Updated

2 months ago
Priority: -- → P2
(Reporter)

Comment 1

2 months ago

Fenix plans to implement its battery-saving mode in M4, so GV should provide its dark mode API in M3 (assuming dark mode is still part of the battery-saving mode).

https://github.com/mozilla-mobile/fenix/issues/240

Whiteboard: [geckoview:fenix:p2] → [geckoview:fenix:m3]
Depends on: 1532850
(Reporter)

Comment 2

2 months ago

Moving to Fenix M4 milestone because the Fenix team is not blocked by this bug.

Whiteboard: [geckoview:fenix:m3] → [geckoview:fenix:m4]
(Assignee)

Updated

a month ago
Assignee: nobody → mbrubeck
(Reporter)

Comment 3

a month ago

Dark mode settings have been deferred from Fenix 1.0, so I'm moving this bug from Fenix M4 to Fenix P3 (post- Fenix 1.0 work).

Fenix will ship GV 67. Android support for prefers-color-scheme (bug 1532850) landed in 68 Nightly, so that bug would also need to be uplifted to GV 67 Beta if we wanted dark mode in Fenix 1.0.

Whiteboard: [geckoview:fenix:m4] → [geckoview:fenix:p3]
(Reporter)

Comment 4

a month ago

67=affected because prefers-color-scheme ("CSS dark mode") is still planned for Fenix MVP. We'll need to uplift this API to 67 Beta.

Priority: P2 → P1
Whiteboard: [geckoview:fenix:p3] → [geckoview:fenix:m4]
(Reporter)

Comment 5

26 days ago

Fenix issue https://github.com/mozilla-mobile/fenix/issues/1164 says the Fenix team plans to implement the setting UI in Fenix M4 milestone, so we should try to land the GV API for the M3 milestone.

Summary: GV API to toggle CSS prefers-color-scheme media feature (aka Dark Mode) → GV API to toggle CSS prefers-color-scheme media query (aka CSS Dark Mode)
Whiteboard: [geckoview:fenix:m4] → [geckoview:fenix:m3]

Comment 8

19 days ago
Pushed by mbrubeck@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0d5da6e22753
Add GeckoView API to control CSS prefers-color-scheme query. r=esawin,geckoview-reviewers

Comment 9

19 days ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 19 days ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
(Reporter)

Comment 10

17 days ago

67=wontfix. Neither Fenix MVP nor Firefox for Fire TV will use GeckoView 67, so we don't need to uplift this fix to 67 Beta.

You need to log in before you can comment on or make changes to this bug.