1529981 - ArenasToUpdate::shouldProcess is dead code

Status: RESOLVED FIXED

(Core :: JavaScript: GC, enhancement, P3)

Description

[Steve Fink [:sfink] [:s:]]

It is declared but unimplemented. It should also be removed from a comment.

Comment 1

[ragavendrakumar1994]

Dear Fink, This would be my first time with Mozilla. Could you please guide me on the setup process/where to look at ? I have built a nightly build on Ubuntu earlier, so I would just like to know where in the code base I should start ?

Comment 2

[Paul Bone [:pbone]]

Hi ragavendrakumar1994, a great way to get someone's attention on bugzilla is to click the "need info" checkbox, but I can answer for sfink. In the textbox you can type ":sfinK" to search for sfink or :pbone for myself etc.

First you can use searchfox.org, it's a search engine for the Firefox code base. it says the code you're looking for (in the title of the bug) is here:

https://searchfox.org/mozilla-central/source/js/src/gc/GC.cpp#2561

Here is a bonus tip:

Because this code is in js/src/ you probably don't need to build firefox to test it. Try these instructions:
https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/Build_Documentation

I suggest using ./configure --enable-debug --enable-optimize most of the time.

There's some instructions for running some tests locally there too.

This is a really simple change, if it were more complex I'd also suggest running it through our cloud testing stuff:
https://wiki.mozilla.org/ReleaseEngineering/TryServer

Here's some general info: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction

Comment 3

[Vaishnavi Kaulagi]

Can I try this one?

Comment 4

[Paul Bone [:pbone]]

Hi Valshnavi, You can take it if ragavendiakumar doesn't want it. Let's wait a week for them to reply to this.

Comment 5

[ragavendrakumar1994]

Dear Paul Bone, My sincere apologies for the late reply, this is not my usual promptness, and thank you for taking the time to explain this in detail. However, I'm occupied (with other coursework) now and I don't think I can follow this up end to end, given that I haven't made any contributions yet. I will try a different bug next time.

Dear Vaishnavi Kaulagi, Please go ahead and fix this one when you get a chance.

Thanks again to both of you for considering to wait for me.

-Ragav

Comment 6

[Khyati Agarwal]

Hi, I'm an Outreachy applicant. Can I work on this?

https://searchfox.org/mozilla-central/source/js/src/gc/GC.cpp#2561

This leads to a blank line in the code.

Comment 7

[Khyati Agarwal]

Attachment: bug 1529981 - ArenasToUpdate::shouldProcess is dead code

ArenasToUpdate::shouldProcessKind() removed

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9102e660cb6f
ArenasToUpdate::shouldProcess is dead code r=sfink

Comment 9

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/9102e660cb6f