Closed Bug 1530019 Opened 8 months ago Closed 8 months ago

JavaScript Error: "actor.cleanup is not a function"

Categories

(Toolkit :: Async Tooling, defect, P1)

64 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: Felipe, Assigned: Felipe)

References

Details

Attachments

(1 file)

Since the cleanup() function has been removed from the base class, only actors that implement it have the function defined.

Attached patch actorfix.patchSplinter Review
Assignee: nobody → felipc
Attachment #9046043 - Flags: review?(mconley)
Comment on attachment 9046043 [details] [diff] [review]
actorfix.patch

Review of attachment 9046043 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, since it mirrors what we do for init. I wonder if we should make this less obscure though by adding init() and cleanup() to the base class as no-ops to be overridden. Maybe worth filing as a follow-up.
Attachment #9046043 - Flags: review?(mconley) → review+
Pushed by felipc@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/75f417cfd0d2
Check if actor.cleanup() exists before trying to call it. r=mconley
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.