Closed Bug 1530034 Opened 7 years ago Closed 7 years ago

Cleanup BytecodeEmitter field initialization

Categories

(Core :: JavaScript Engine, enhancement, P3)

Product:
Core
Component:
JavaScript Engine
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: tcampbell, Assigned: tcampbell)

Details

Attachments

(2 files, 1 obsolete file)

Bug 1530034 - Use mozilla::Maybe in BytecodeEmitter when reasonable. r?jorendorff
47 bytes, text/x-phabricator-request
Details | Review
Bug 1530034 - Use default initializers for BytecodeEmitter fields. r?jorendorff
47 bytes, text/x-phabricator-request
Details | Review

Migrate the giant constructor initialization list to field default values instead. Also some miscellaneous cleanups.

Also replace a few packed bitfields with normal fields since this is a
stack type only.

Depends on D20885

Attachment #9046067 - Attachment is obsolete: true
Pushed by tcampbell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a69e03c02d34 Use mozilla::Maybe in BytecodeEmitter when reasonable. r=jorendorff https://hg.mozilla.org/integration/autoland/rev/942730f2550d Use default initializers for BytecodeEmitter fields. r=jorendorff

https://hg.mozilla.org/mozilla-central/rev/a69e03c02d34
https://hg.mozilla.org/mozilla-central/rev/942730f2550d

Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: