1530038 - mach try fuzzy -q linux64 shouldn't run toolchain tasks

Status: RESOLVED FIXED

(Developer Infrastructure :: Try, enhancement)

Description

[Mike Hommey [:glandium]]

Per bug 1529963 comment 4, this changeset: https://hg.mozilla.org/try/rev/485ddfae103f6ea51a16ff580bf9540a503193c3 was created with mach try fuzzy -q linux64. Note how all the toolchain-linux64 jobs are explicitly run in this case. They shouldn't.

Comment 1

[Mike Hommey [:glandium]]

That might be because bug 1509048 changed

attr = 'full_task_set' if full else 'target_task_set'

to

attr = 'full_task_graph' if full else 'target_task_graph'

Comment 2

[Tom Prince [:tomprince]]

:ahal, were there some particular tasks that were in the target graph, but not the target set that motivated this change, or would it make sense to revert it.

Comment 3

[Andrew Halberstadt [:ahal]]

Attachment: Tasks in target graph but not target set

I bet I assumed I needed to switch to 'graph' to get a TaskGraph object at the time. Looking at the set of impacted tasks, it seems 100% reasonable to revert this change.

I'll take this as I've been meaning to switch the cache location to use the new srcdir state dir anyway and might as well land these changes together to reduce cache invalidations.

Comment 4

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1530038 - [tryselect] Use target_task_set instead of target_task_graph, r?tomprince

The graph contains some extra things like toolchains, fetches and packaging
tasks that people will almost never want to run on their own. This change gets
them out of the default fuzzy selection interface, and makes it so --full is
needed to schedule them.

Comment 5

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1530038 - [tryselect] Move taskgraph cache to new srcdir state location, r?tomprince

Depends on D24187

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/accac7774507
[tryselect] Use target_task_set instead of target_task_graph, r=tomprince
https://hg.mozilla.org/integration/autoland/rev/11bd94613758
[tryselect] Move taskgraph cache to new srcdir state location, r=tomprince

Comment 7

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/accac7774507
https://hg.mozilla.org/mozilla-central/rev/11bd94613758