Closed Bug 1530098 Opened 10 months ago Closed 8 months ago

Update libc crate to 0.2.51

Categories

(Core :: General, enhancement)

Unspecified
FreeBSD
enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox65 --- wontfix
firefox66 --- wontfix
firefox67 --- wontfix
firefox68 --- fixed

People

(Reporter: jbeich, Assigned: jbeich)

References

Details

Attachments

(1 file, 2 obsolete files)

Attached patch v1 (obsolete) — Splinter Review

(Sorry, I can't upload on Phabricator due to MFA policy which is incompatible with GitHub login)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a18c91a5c7125b51bd0a24376f7e7c0e4a4b353f

Assignee: nobody → jbeich
Attachment #9046121 - Flags: review?(nfroyd)
Comment on attachment 9046121 [details] [diff] [review]
v1

Generated by:

$ cargo update -p libc
$ ./mach vendor rust

Fails no Windows aarch64. Is this a known issue?

14:12:02 INFO - LLVM ERROR: SEH unwind data splitting not yet implemented
14:12:02 ERROR - error: Could not compile style.

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=230082805&repo=try&lineNumber=20252-20253

Flags: needinfo?(dmajor)

We dealt with this issue before for C++, but this is the first time it's come up in Rust. It sounds like rustc's copy of LLVM will need to merge https://bugs.llvm.org/show_bug.cgi?id=40311.

Though I'm kind of surprised that rustc is doing SEH stuff on aarch64-windows, as that too was only recently implemented in LLVM, not long before the bugfix above. What revision of LLVM does rustc use? I wonder if there are more patches from around that time that they'd want to merge.

Flags: needinfo?(dmajor)
Depends on: 1530448
Comment on attachment 9046121 [details] [diff] [review]
v1

Review of attachment 9046121 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry, I thought I had r+'d this!
Attachment #9046121 - Flags: review?(nfroyd) → review+

Jan, as you still planning to land that?

Flags: needinfo?(jbeich)
Status: NEW → ASSIGNED

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:jbeich, could you have a look please?

Flags: needinfo?(jbeich)
Attached patch v1 (obsolete) — Splinter Review
Attachment #9046121 - Attachment is obsolete: true
Flags: needinfo?(jbeich)
Keywords: checkin-needed
Summary: Update libc crate to 0.2.49 → Update libc crate to 0.2.51

Jan, I've received hunk failed while applying this patch:

"applying bug1530098.diff
patching file Cargo.lock
Hunk #1 FAILED at 73
Hunk #7 succeeded at 859 with fuzz 1 (offset 0 lines).
Hunk #9 FAILED at 939
Hunk #28 succeeded at 2396 with fuzz 2 (offset 0 lines).
Hunk #36 succeeded at 3316 with fuzz 2 (offset 0 lines).
2 out of 39 hunks FAILED -- saving rejects to file Cargo.lock.rej"

Can you please take a look?

Flags: needinfo?(jbeich)
Keywords: checkin-needed
Attached patch v1Splinter Review

Rebase after bug 1529117 hit mozilla-central.

Attachment #9056021 - Attachment is obsolete: true
Flags: needinfo?(jbeich)
Keywords: checkin-needed

Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/40052223c3a2
Update libc crate to 0.2.51 to pick up FreeBSD fixes for non-x86. r=froydnj

Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.