[perf] remove RDF graph from content model construction process

VERIFIED FIXED in M11

Status

()

defect
P1
critical
VERIFIED FIXED
20 years ago
11 years ago

People

(Reporter: waterson, Assigned: waterson)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [perf] awaiting code review w/ hyatt)

Profiling has shown content model construction to dominate (~40%) of the cost.
Much of the time is spent converting data into, and then out of, and RDF graph.
(The graph adds value for overlays and persistence.) Re-implement, without RDF
graph.
Severity: normal → critical
Status: NEW → ASSIGNED
Priority: P3 → P1
Whiteboard: [perf] hacking on it
Target Milestone: M11
Moved work into XUL_19990930_BRANCH, which has been cut from mozilla/rdf on
down. (I mostly did this because my system is starting to show signs of OS
rot.) But if anyone wants to take a look, pitch in, whatever, feel free.
shaver and i got this mostly working tonight. clawing away at a couple weird
bugs. browser comes up. sidebar usually does to. mailnews can seem to find
folder objects.
okay, a quick-n-dirty "before vs. after" looks like we may have won a 15%
improvement in open new window (beware, sample size == 1). Before the changes,
opening new window on about:blank sans-a-sidebar took 1.7s; after it took 1.4s.

we still aren't bug-complete, need to finish persistence and pick mailnews off
the floor. scottip: AFAICT the mialnews problem has to do with the fact that
we're no longer indexing the element map with resource objects; hence, we drop
references to the mailnews resources pretty eagerly. I was thinking we could
fix this by stuffing a resource reference into the element itself. what do you
think?
Whiteboard: [perf] hacking on it → [perf] hacking on it TTF=1d
Rolled changes forward to XUL_19991001_BRANCH; fixed problems with mailnews.
Just need to scuttle persistence and we should be ready to land...
Depends on: 15460
Depends on: 15511
Whiteboard: [perf] hacking on it TTF=1d → [perf] awaiting code review w/ hyatt
this is ready to go. hyatt and I are gonna walk thru it tomorrow and land.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
checked in, r=hyatt,shaver.
Chris, could you verify this bug?  I'll mark it verified by Wednesday if I
havent' heard from you...
Status: RESOLVED → VERIFIED
BULK MOVE: Changing component from XUL to XP Toolkit/Widgets: XUL.  XUL 
component will be deleted.
Component: XUL → XP Toolkit/Widgets: XUL
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: ckritzer → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.