Closed Bug 1530140 Opened 9 months ago Closed 9 months ago

Change Netmonitor's localization access keys to lower case

Categories

(DevTools :: Netmonitor, enhancement, P3)

67 Branch
enhancement

Tracking

(firefox67 fixed)

RESOLVED FIXED
Firefox 67
Tracking Status
firefox67 --- fixed

People

(Reporter: tanhengyeow, Assigned: tanhengyeow)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/72.0.3626.119 Safari/537.36

Steps to reproduce:

According to the discussion here:

Accesskeys are case sensitive, and have a fallback mechanism. Es, label "Copy code":

Accesskey="C". The first C will be used, matching the case.
Accesskey="c". The *c* in *code* will be used, matching the case.
Accesskey="O". Since there's no perfect matching for case, it will fall back to the *o* in copy.

What's the point of triggering the fallback mechanism, when the accesskey could just match directly the right case?

Actual results:

All access keys in netmonitor.properties are named in upper case by default.

Expected results:

We should rename all access keys in netmonitor.properties to be lower case so that we do not trigger the fallback mechanism unnecessarily.

Changed all access keys to upper case

Hi Honza

Patch ready for review :)

Flags: needinfo?(odvarko)

(In reply to Heng Yeow (:tanhengyeow) from comment #0)

We should rename all access keys in netmonitor.properties to be lower case so that we do not trigger the fallback mechanism unnecessarily.

That's not true. You should match the case of the character on the label. Putting everything lowercase has exactly the same problem of the current situation.

Review done in Phabricator:

R+ if try is green
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1a572872c34af45a7caea982be8cf154cba24c0e

Btw. you can land patches through Phabricator UI, correct?

Honza

Flags: needinfo?(odvarko)

Not yet, that is only allowed with Commit Level 3 :) Also, could assign me this issue? Thanks!!

Flags: needinfo?(odvarko)

(In reply to Heng Yeow (:tanhengyeow) from comment #5)

Not yet, that is only allowed with Commit Level 3 :)
Ah, I see

Also, could assign me this issue? Thanks!!
Done!

Honza

Assignee: nobody → E0032242
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Flags: needinfo?(odvarko)
Priority: -- → P3
Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/34b250d8bddf
Change Netmonitor's localization access keys to lower case. r=Honza,flod
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.