Replace promiseWaitForCondition with TestUtils.waitForCondition in browser_double_close_tab.js

RESOLVED FIXED in Firefox 67

Status

()

enhancement
P5
normal
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: johannh, Assigned: jjo, Mentored)

Tracking

(Blocks 1 bug, {good-first-bug})

unspecified
Firefox 67
Points:
---

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 months ago

This is a good first bug for newcomers to Firefox development.

promiseWaitForCondition in the browser_double_close_tab.js test file can be replaced by the TestUtils.waitForCondition utility function.

The code in question is here: https://searchfox.org/mozilla-central/rev/dc0adc07db3df9431a0876156f50c65d580010cb/browser/base/content/test/general/browser_double_close_tab.js#69

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://developer.mozilla.org/en-US/docs/Introduction.

You can run this test with the ./mach mochitest command:

./mach mochitest browser/base/content/test/general/browser_double_close_tab.js

Please leave a comment if you would like to be assigned to this bug and feel free to ask questions here or via IRC if you're stuck.

(Assignee)

Comment 1

3 months ago

Hi Johann, it's Jojo! Is it possible if this bug could be assigned to me? Thanks!

Comment 2

3 months ago

Hey! Can I take up this issue? I'm a 2019 Outreachy applicant

(Reporter)

Comment 3

3 months ago

Joanna was first. :)

Aashna, I'll open up a bunch of new bugs later and let you know.

Assignee: nobody → jjo.su1822
Status: NEW → ASSIGNED

Comment 4

3 months ago

Hi Joanna and Johann. I am an Outreachy applicant. I see this bug is not resolved in almost a week. If you are not working on it Joanna can I be assigned to it by Johann?
Thank you!

(Assignee)

Comment 5

3 months ago

(In reply to Viktor from comment #4)

Hi Joanna and Johann. I am an Outreachy applicant. I see this bug is not resolved in almost a week. If you are not working on it Joanna can I be assigned to it by Johann?
Thank you!

Hi Viktor, I've actually solved this bug! It was just taking a bit to set up my dev environment, but I'll be submitting a patch for this soon.

(Assignee)

Comment 6

3 months ago

Changed promiseWaitForCondition in line 69 to TestUtils.waitForCondition

Comment 7

3 months ago

(In reply to Joanna Jo [:jjo] from comment #5)

(In reply to Viktor from comment #4)

Hi Joanna and Johann. I am an Outreachy applicant. I see this bug is not resolved in almost a week. If you are not working on it Joanna can I be assigned to it by Johann?
Thank you!

Hi Viktor, I've actually solved this bug! It was just taking a bit to set up my dev environment, but I'll be submitting a patch for this soon.

Great. I'm glad everything worked out. Cheers!

(Reporter)

Comment 8

3 months ago

Setting checkin-needed to get this landed...

Keywords: checkin-needed

Comment 9

3 months ago

Pushed by dluca@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b6c437beca62
Replace promiseWaitForCondition with TestUtils.waitForCondition in browser_double_close_tab.js r=johannh

Keywords: checkin-needed

Comment 10

3 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67

Comment 12

3 months ago
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/79c8caa86612
Replace promiseWaitForCondition with TestUtils.waitForCondition in browser_double_close_tab.js r=johannh

Wrong backout, I relanded this. Marking the backout comment as obsolete.

Comment 14

3 months ago

Is this bug resolved? Can this be assigned to me?? I am an outreachy applicant.

You need to log in before you can comment on or make changes to this bug.