Closed Bug 1530179 Opened 2 years ago Closed 2 years ago

Replace promiseWaitForCondition with TestUtils.waitForCondition in browser_double_close_tab.js

Categories

(Firefox :: General, enhancement, P5)

Product:
Firefox
Component:
General
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: johannh, Assigned: jjo, Mentored)

References

Details

(Keywords: good-first-bug)

Attachments

(1 file)

Bug 1530179: Replace promiseWaitForCondition with TestUtils.waitForCondition in browser_double_close_tab.js
47 bytes, text/x-phabricator-request
Details | Review

This is a good first bug for newcomers to Firefox development.

promiseWaitForCondition in the browser_double_close_tab.js test file can be replaced by the TestUtils.waitForCondition utility function.

The code in question is here: https://searchfox.org/mozilla-central/rev/dc0adc07db3df9431a0876156f50c65d580010cb/browser/base/content/test/general/browser_double_close_tab.js#69

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://developer.mozilla.org/en-US/docs/Introduction.

You can run this test with the ./mach mochitest command:

./mach mochitest browser/base/content/test/general/browser_double_close_tab.js

Please leave a comment if you would like to be assigned to this bug and feel free to ask questions here or via IRC if you're stuck.

Hi Johann, it's Jojo! Is it possible if this bug could be assigned to me? Thanks!

Hey! Can I take up this issue? I'm a 2019 Outreachy applicant

Joanna was first. :)

Aashna, I'll open up a bunch of new bugs later and let you know.

Assignee: nobody → jjo.su1822
Status: NEW → ASSIGNED

Hi Joanna and Johann. I am an Outreachy applicant. I see this bug is not resolved in almost a week. If you are not working on it Joanna can I be assigned to it by Johann?
Thank you!

(In reply to Viktor from comment #4)

Hi Joanna and Johann. I am an Outreachy applicant. I see this bug is not resolved in almost a week. If you are not working on it Joanna can I be assigned to it by Johann?
Thank you!

Hi Viktor, I've actually solved this bug! It was just taking a bit to set up my dev environment, but I'll be submitting a patch for this soon.

Changed promiseWaitForCondition in line 69 to TestUtils.waitForCondition

(In reply to Joanna Jo [:jjo] from comment #5)

(In reply to Viktor from comment #4)

Hi Joanna and Johann. I am an Outreachy applicant. I see this bug is not resolved in almost a week. If you are not working on it Joanna can I be assigned to it by Johann?
Thank you!

Hi Viktor, I've actually solved this bug! It was just taking a bit to set up my dev environment, but I'll be submitting a patch for this soon.

Great. I'm glad everything worked out. Cheers!

Setting checkin-needed to get this landed...

Keywords: checkin-needed

Pushed by dluca@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b6c437beca62
Replace promiseWaitForCondition with TestUtils.waitForCondition in browser_double_close_tab.js r=johannh

Keywords: checkin-needed

https://hg.mozilla.org/mozilla-central/rev/b6c437beca62

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/79c8caa86612
Replace promiseWaitForCondition with TestUtils.waitForCondition in browser_double_close_tab.js r=johannh

Wrong backout, I relanded this. Marking the backout comment as obsolete.

Is this bug resolved? Can this be assigned to me?? I am an outreachy applicant.

You need to log in before you can comment on or make changes to this bug.