Replace promiseWaitForCondition with TestUtils.waitForCondition in browser_bug1015721.js

RESOLVED FIXED in Firefox 67

Status

()

enhancement
P5
normal
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: johannh, Assigned: danielleleb12, Mentored)

Tracking

({good-first-bug})

unspecified
Firefox 67
Points:
---

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

Reporter

Description

3 months ago

This is a good first bug for newcomers to Firefox development.

promiseWaitForCondition in the browser_bug1015721.js test file can be replaced by the TestUtils.waitForCondition utility function.

The code in question is here: https://searchfox.org/mozilla-central/rev/dc0adc07db3df9431a0876156f50c65d580010cb/browser/base/content/test/general/browser_bug1015721.js#35

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://developer.mozilla.org/en-US/docs/Introduction.

You can run this test with the ./mach mochitest command:

./mach mochitest browser/base/content/test/general/browser_bug1015721.js

Please leave a comment if you would like to be assigned to this bug and feel free to ask questions here or via IRC if you're stuck.

Assignee

Comment 1

3 months ago

Hi there, I'd like to this bug to be assigned to me if still available.

Comment 2

3 months ago

Hey, I'd like to take up this bug. Can you please assign this to me?

Reporter

Comment 3

3 months ago

Hi danielleleb12, let me know if I can help you in any way.

Aashna, as mentioned, I'll send you another bug you can take soon. Thanks!

Assignee: nobody → danielleleb12
Status: NEW → ASSIGNED

Comment 4

3 months ago

Sure, I'm willing to take up any issues fit for beginners. Please assign me as soon as one is available!

Assignee

Comment 5

3 months ago

Hi :johannh, I'm about to submit the patch. I'm just wondering how I should handle submitting the commit, as I have a commit from a previous patch for another issue that shows up when I run moz-phab (along with the new commit for this issue).

Should I remove that previous commit before submitting? And if so, is there a better way of doing it than with hg histedit?

Just want to make sure I don't accidentally create another issue when submitting this patch.

Thanks in advance for the help!

Reporter

Comment 6

3 months ago

(In reply to danielleleb12 from comment #5)

Hi :johannh, I'm about to submit the patch. I'm just wondering how I should handle submitting the commit, as I have a commit from a previous patch for another issue that shows up when I run moz-phab (along with the new commit for this issue).

Should I remove that previous commit before submitting? And if so, is there a better way of doing it than with hg histedit?

Just want to make sure I don't accidentally create another issue when submitting this patch.

Thanks in advance for the help!

You could try rebasing on top of central, using hg rebase:

hg rebase -d central -s <your commit id>

Let me know if that helps.

Reporter

Comment 8

3 months ago

Thank you for the contribution. I've given you editbugs privileges, which means you can now edit all bugs. Please use your new powers wisely. The first thing you can do is update the "keywords" attribute of this bug to include checkin-needed, which will get your patch checked in :)

Assignee

Updated

3 months ago
Keywords: checkin-needed

Comment 9

3 months ago

Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c0df44b239b5
Replaces promiseWaitForCondition with TestUtils.waitForCondition. r=johannh

Keywords: checkin-needed
Reporter

Comment 10

3 months ago

Hey danielleleb12, thank you for your contribution and well done!

Are you looking for more work? I'm happy to dig something up! Also, are you an Outreachy candidate or just fixing bugs for fun? :)

Thanks!

Johann

Comment 11

3 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
Assignee

Comment 12

3 months ago

Hey Johann, no problem, I am happy to help and get involved!

Some more bugs would be great! I am an Outreachy applicant. I have another bug underway on DevTools - is that something I could also include with the Outreachy application, or is there a specific area of Firefox I should be focusing my work on?

Thanks for all of the help!

Reporter

Comment 13

3 months ago

Awesome, that's great to hear! While we appreciate any contribution to Firefox in your application, it is easier for us to (positively) evaluate you if you work on bugs that are within our area of knowledge/responsibility.

Do you think you'd have time to take a look at bug 1489874? I left instructions in the bottom comment and I'm happy to answer any questions you may have (I also recommend getting in touch with me on IRC if you're looking for faster communication cycles).

Thanks!

Assignee

Comment 14

3 months ago

Cool, thanks for the info!

I would be happy to work on it - should I ask for it to be assigned to me, or just work on the patch? (Still not 100% sure what the etiquette is for claiming/working on bugs here).

Reporter

Comment 15

3 months ago

(In reply to danielleleb12 from comment #14)

Cool, thanks for the info!

I would be happy to work on it - should I ask for it to be assigned to me, or just work on the patch? (Still not 100% sure what the etiquette is for claiming/working on bugs here).

We often tend to say "submit a patch to get assigned" but with the amount of Outreachy applicants currently churning through bugs I'd like to make sure that folks don't duplicate work, so I'll assign you if you don't mind.

Assignee

Comment 16

3 months ago

Excellent - thanks so much!

You need to log in before you can comment on or make changes to this bug.