1530183 - Replace promiseWaitForCondition with TestUtils.waitForCondition in browser/base/content/test/webrtc/head.js

Status: RESOLVED FIXED

(Firefox :: Site Permissions, enhancement, P5)

Description

[Johann Hofmann [:johannh]]

This is a good first bug for newcomers to Firefox development.

promiseWaitForCondition in browser/base/content/test/webrtc/head.js can be replaced by the TestUtils.waitForCondition utility function.

The code in question is here: https://searchfox.org/mozilla-central/rev/dc0adc07db3df9431a0876156f50c65d580010cb/browser/base/content/test/webrtc/head.js#96

You can also remove the function definition: https://searchfox.org/mozilla-central/rev/dc0adc07db3df9431a0876156f50c65d580010cb/browser/base/content/test/webrtc/head.js#37

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://developer.mozilla.org/en-US/docs/Introduction.

After your change it might be a good idea to run all WebRTC UI tests with the ./mach mochitest command:

./mach mochitest browser/base/content/test/webrtc/

Please leave a comment if you would like to be assigned to this bug and feel free to ask questions here or via IRC if you're stuck.

Comment 1

[Carolina Jimenez Gomez]

Hello, I'm an outreachy applicant, can I try to solve this bug?

Comment 2

[Johann Hofmann [:johannh]]

Absolutely, let me know if you're stuck!

Comment 3

[Carolina Jimenez Gomez]

Attachment: Change promiseWaitForCondition for TestUtils.waitForCondition

however, in the file head.js other functions use BrowserTestUtils instead of TestUtils, so I wasn't sure which of those is the
correct one, so I used the one suggested in the issue.

Comment 4

[Carolina Jimenez Gomez]

Also BrowserTestUtils and TestUtils both passed the tests with the command ./mach mochitest browser/base/content/test/webrtc/

Comment 5

[Johann Hofmann [:johannh]]

Thanks! To get this patch landed you will need to set the checkin-needed flag on the bug. This time I've done it for you :)

Comment 6

[Carolina Jimenez Gomez]

Thank you! how did you added?

Comment 7

[Carolina Jimenez Gomez]

how did you add it?***

Comment 8

[Johann Hofmann [:johannh]]

I think you need editbugs privileges, which you will usually get after working on two bugs :)

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45bc26c5c749
Change promiseWaitForCondition for TestUtils.waitForCondition r=johannh

Comment 10

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/45bc26c5c749

Comment 11

[Carolina Jimenez Gomez]

I can be wrong but I think there are problems blocking the cookies, here are them:

1. When a person add a url that doesn't even exist like putting just "facebook" it let you do it. I don't know if is the correct behavior.

2. When I add facebook.com and I go to google.com it shows like if we had added google in the list of blocked cookies, but I didn't.

I would like to attach some images regarding this behavior but I don't know how to do it...

Comment 12

[Carolina Jimenez Gomez]

Sorry, I commented on the wrong issue