Rename accentcolor so theme authors can understand its purpose
Categories
(WebExtensions :: Themes, enhancement, P5)
Tracking
(Not tracked)
People
(Reporter: dao, Unassigned)
References
Details
accentcolor is a constant source of confusion due to its vague name. Theme authors set to bogus or stupid values because they don't understand its purpose.
See the discussion in bug 1508154 and bug 1508154 comment 4 in particular for how we could approach renaming this property.
|
||
Comment 1•5 years ago
|
||
accentcolor has been deprecated, and the google chrome name (colors.frame) has to be used instead.
|
Reporter | |
Comment 2•5 years ago
|
||
This is surprising since mconca said in bug 1508154 that we don't do deprecation / aliasing. Accentcolor is actually still supported from what I can tell by looking at ext-theme.js. Are we going to remove this?
|
|
Reporter | |
Updated•5 years ago
|
|
|
||
Comment 3•5 years ago
|
||
(In reply to Dão Gottwald [::dao] from comment #2)
This is surprising since mconca said in bug 1508154 that we don't do deprecation / aliasing. Accentcolor is actually still supported from what I can tell by looking at ext-theme.js. Are we going to remove this?
Yes, in Firefox 69.
|
|
Reporter | |
Comment 4•5 years ago
|
||
(In reply to Tim Nguyen :ntim from comment #3)
(In reply to Dão Gottwald [::dao] from comment #2)
This is surprising since mconca said in bug 1508154 that we don't do deprecation / aliasing. Accentcolor is actually still supported from what I can tell by looking at ext-theme.js. Are we going to remove this?
Yes, in Firefox 69.
Is there a bug for that?
I see that textcolor is deprecated too in favor of tab_background_text, which is problematic again because that color is used in other contexts such as the find bar, which brings us back to bug 1506913.
|
||
Updated•5 years ago
|
|
||
Comment 5•5 years ago
|
||
(In reply to Dão Gottwald [::dao] from comment #4)
(In reply to Tim Nguyen :ntim from comment #3)
(In reply to Dão Gottwald [::dao] from comment #2)
This is surprising since mconca said in bug 1508154 that we don't do deprecation / aliasing. Accentcolor is actually still supported from what I can tell by looking at ext-theme.js. Are we going to remove this?
Yes, in Firefox 69.
Is there a bug for that?
accentcolor is being deprecated in Firefox 69.
https://bugzilla.mozilla.org/show_bug.cgi?id=1472740
|
||
Comment 6•5 years ago
|
||
(In reply to Mike Conca [:mconca] from comment #5)
accentcolor is being deprecated in Firefox 69.
https://bugzilla.mozilla.org/show_bug.cgi?id=1472740
Unfortunately, the AMO static theme migration generated extensions using deprecated aliases, so unless we do another migration, I'm not sure this will actually be possible.
|
|
||
Comment 7•5 years ago
|
||
(In reply to Kris Maglione [:kmag] from comment #6)
(In reply to Mike Conca [:mconca] from comment #5)
accentcolor is being deprecated in Firefox 69.
https://bugzilla.mozilla.org/show_bug.cgi?id=1472740Unfortunately, the AMO static theme migration generated extensions using deprecated aliases, so unless we do another migration, I'm not sure this will actually be possible.
AMO will be doing another migration to the non-deprecated properties.
See https://github.com/mozilla/addons-server/issues/10627
Description
•