1530277 - Replace promiseWaitForEvent in browser_findbarClose.js with BrowserTestUtils.waitForEvent

Status: RESOLVED FIXED

(Firefox :: General, enhancement, P5)

Description

[Johann Hofmann [:johannh]]

This is a good first bug for newcomers to Firefox development.

promiseWaitForEvent in the browser_findbarClose.js test file can be replaced by the BrowserTestUtils.waitForEvent utility function.

The code in question is here: https://searchfox.org/mozilla-central/rev/dc0adc07db3df9431a0876156f50c65d580010cb/browser/base/content/test/general/browser_findbarClose.js#30

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://developer.mozilla.org/en-US/docs/Introduction.

You can run this test with the ./mach mochitest command:

./mach mochitest browser/base/content/test/general/browser_findbarClose.js

Please leave a comment if you would like to be assigned to this bug and feel free to ask questions here or via IRC if you're stuck.

Comment 1

[Monika Maheshwari [:MonikaMaheshwari]]

Hey I want to work on this issue. Can you direct me to the codebase for this bug?

Comment 2

[Johann Hofmann [:johannh]]

Hi Monika, see comment 0, you can find instructions on how to get mozilla-central on https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction (it's a bit long but you should read it)

Comment 3

[Monika Maheshwari [:MonikaMaheshwari]]

Hi, thanks. Will first setup local build of Firefox and will try to work on it.

Comment 4

[Monika Maheshwari [:MonikaMaheshwari]]

Hi, getting abort: stream ended unexpectedly (got 14694 bytes, expected 32768) error when hg clone. Can you help me with this.

Comment 5

[Monika Maheshwari [:MonikaMaheshwari]]

Hi, have used bundle to download source.

Comment 6

[Johann Hofmann [:johannh]]

Ok, so, do things work on your end now? :)

Comment 7

[Monika Maheshwari [:MonikaMaheshwari]]

Hi, I am able to run and fix the bug. But having doubt on submitting the patch. Do I need to commit the change on the same branch and then where to submit the patch.

Comment 8

[Johann Hofmann [:johannh]]

Awesome, that's great to hear! Yes, you should just commit on top of central and then use phabricator to submit the patch: https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html

Comment 9

[Monika Maheshwari [:MonikaMaheshwari]]

Have submit the patch: https://phabricator.services.mozilla.com/D21366. But in Details it is showing Bugzilla Bug ID Not provided

Comment 10

[Monika Maheshwari [:MonikaMaheshwari]]

Attachment: Bug 1530277 BrowserTestUtils.waitForEvent added in browser_findbarClose.js

Have replace promiseWaitForEvent in browser_findbarClose.js with BrowserTestUtils.waitForEvent

Comment 11

[Johann Hofmann [:johannh]]

Great work! Let me set the checkin-needed flag so that someone lands this for us.

Comment 12

[Monika Maheshwari [:MonikaMaheshwari]]

Hi, Thanks for helping :). Would be great if you can help me on which bug to work on next. I am outreachy applicant.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa3eeabe6372
BrowserTestUtils.waitForEvent added in browser_findbarClose.js r=johannh

Comment 14

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/aa3eeabe6372