Closed Bug 1530277 Opened 9 months ago Closed 9 months ago

Replace promiseWaitForEvent in browser_findbarClose.js with BrowserTestUtils.waitForEvent

Categories

(Firefox :: General, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 67
Tracking Status
firefox67 --- fixed

People

(Reporter: johannh, Assigned: MonikaMaheshwari, Mentored)

References

Details

(Keywords: good-first-bug)

Attachments

(1 file)

This is a good first bug for newcomers to Firefox development.

promiseWaitForEvent in the browser_findbarClose.js test file can be replaced by the BrowserTestUtils.waitForEvent utility function.

The code in question is here: https://searchfox.org/mozilla-central/rev/dc0adc07db3df9431a0876156f50c65d580010cb/browser/base/content/test/general/browser_findbarClose.js#30

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://developer.mozilla.org/en-US/docs/Introduction.

You can run this test with the ./mach mochitest command:

./mach mochitest browser/base/content/test/general/browser_findbarClose.js

Please leave a comment if you would like to be assigned to this bug and feel free to ask questions here or via IRC if you're stuck.

Hey I want to work on this issue. Can you direct me to the codebase for this bug?

Hi Monika, see comment 0, you can find instructions on how to get mozilla-central on https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction (it's a bit long but you should read it)

Assignee: nobody → monikamaheshwari1996
Status: NEW → ASSIGNED

Hi, thanks. Will first setup local build of Firefox and will try to work on it.

Hi, getting abort: stream ended unexpectedly (got 14694 bytes, expected 32768) error when hg clone. Can you help me with this.

Hi, have used bundle to download source.

Ok, so, do things work on your end now? :)

Hi, I am able to run and fix the bug. But having doubt on submitting the patch. Do I need to commit the change on the same branch and then where to submit the patch.

Awesome, that's great to hear! Yes, you should just commit on top of central and then use phabricator to submit the patch: https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html

Have submit the patch: https://phabricator.services.mozilla.com/D21366. But in Details it is showing Bugzilla Bug ID Not provided

Have replace promiseWaitForEvent in browser_findbarClose.js with BrowserTestUtils.waitForEvent

Great work! Let me set the checkin-needed flag so that someone lands this for us.

Keywords: checkin-needed

Hi, Thanks for helping :). Would be great if you can help me on which bug to work on next. I am outreachy applicant.

Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/aa3eeabe6372
BrowserTestUtils.waitForEvent added in browser_findbarClose.js r=johannh

Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.