Replace promiseWaitForEvent in browser_tab_dragdrop2.js with BrowserTestUtils.waitForEvent

RESOLVED FIXED in Firefox 67

Status

()

enhancement
P5
normal
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: johannh, Assigned: akshithashetty84, Mentored)

Tracking

({good-first-bug})

unspecified
Firefox 67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

Reporter

Description

3 months ago

This is a good first bug for newcomers to Firefox development.

promiseWaitForEvent in the browser_tab_dragdrop2.js test file can be replaced by the BrowserTestUtils.waitForEvent utility function.

The code in question is here: https://searchfox.org/mozilla-central/rev/dc0adc07db3df9431a0876156f50c65d580010cb/browser/base/content/test/general/browser_tab_dragdrop2.js#24,55

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://developer.mozilla.org/en-US/docs/Introduction.

You can run this test with the ./mach mochitest command:

./mach mochitest browser/base/content/test/general/browser_tab_dragdrop2.js

Please leave a comment if you would like to be assigned to this bug and feel free to ask questions here or via IRC if you're stuck.

Assignee

Comment 1

3 months ago

Hi,
I would like take this one up. Could you please assign it to me?
Thanks.

Reporter

Comment 2

3 months ago

Yup, thank you!

Assignee: nobody → akshithashetty84
Status: NEW → ASSIGNED
Assignee

Comment 3

3 months ago

Replace promiseWaitForEvent in browser_tab_dragdrop2.js with BrowserTestUtils.waitForEvent

Reporter

Comment 4

3 months ago

Thanks! Setting checkin-needed to get this landed for us...

Keywords: checkin-needed
Assignee

Comment 5

3 months ago

Great! Thanks

Comment 6

3 months ago

Pushed by ccoroiu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e2bb36fb5ead
Replace promiseWaitForEvent in browser_tab_dragdrop2.js with BrowserTestUtils.waitForEvent. r=johannh

Keywords: checkin-needed

Comment 7

3 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.