Closed Bug 1530279 Opened 1 year ago Closed 1 year ago

Replace promiseWaitForEvent in browser_tab_dragdrop2.js with BrowserTestUtils.waitForEvent

Categories

(Firefox :: General, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 67
Tracking Status
firefox67 --- fixed

People

(Reporter: johannh, Assigned: akshithashetty84, Mentored)

References

Details

(Keywords: good-first-bug)

Attachments

(1 file)

This is a good first bug for newcomers to Firefox development.

promiseWaitForEvent in the browser_tab_dragdrop2.js test file can be replaced by the BrowserTestUtils.waitForEvent utility function.

The code in question is here: https://searchfox.org/mozilla-central/rev/dc0adc07db3df9431a0876156f50c65d580010cb/browser/base/content/test/general/browser_tab_dragdrop2.js#24,55

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://developer.mozilla.org/en-US/docs/Introduction.

You can run this test with the ./mach mochitest command:

./mach mochitest browser/base/content/test/general/browser_tab_dragdrop2.js

Please leave a comment if you would like to be assigned to this bug and feel free to ask questions here or via IRC if you're stuck.

Hi,
I would like take this one up. Could you please assign it to me?
Thanks.

Yup, thank you!

Assignee: nobody → akshithashetty84
Status: NEW → ASSIGNED

Replace promiseWaitForEvent in browser_tab_dragdrop2.js with BrowserTestUtils.waitForEvent

Thanks! Setting checkin-needed to get this landed for us...

Keywords: checkin-needed

Great! Thanks

Pushed by ccoroiu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e2bb36fb5ead
Replace promiseWaitForEvent in browser_tab_dragdrop2.js with BrowserTestUtils.waitForEvent. r=johannh

Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.