1530279 - Replace promiseWaitForEvent in browser_tab_dragdrop2.js with BrowserTestUtils.waitForEvent

Status: RESOLVED FIXED

(Firefox :: General, enhancement, P5)

Description

[Johann Hofmann [:johannh]]

This is a good first bug for newcomers to Firefox development.

promiseWaitForEvent in the browser_tab_dragdrop2.js test file can be replaced by the BrowserTestUtils.waitForEvent utility function.

The code in question is here: https://searchfox.org/mozilla-central/rev/dc0adc07db3df9431a0876156f50c65d580010cb/browser/base/content/test/general/browser_tab_dragdrop2.js#24,55

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://developer.mozilla.org/en-US/docs/Introduction.

You can run this test with the ./mach mochitest command:

./mach mochitest browser/base/content/test/general/browser_tab_dragdrop2.js

Please leave a comment if you would like to be assigned to this bug and feel free to ask questions here or via IRC if you're stuck.

Comment 1

[akshitha shetty]

Hi,
I would like take this one up. Could you please assign it to me?
Thanks.

Comment 2

[Johann Hofmann [:johannh]]

Yup, thank you!

Comment 3

[akshitha shetty]

Attachment: Bug 1530279 - Replace promiseWaitForEvent in browser_tab_dragdrop2.js with BrowserTestUtils.waitForEvent. r=johannh

Replace promiseWaitForEvent in browser_tab_dragdrop2.js with BrowserTestUtils.waitForEvent

Comment 4

[Johann Hofmann [:johannh]]

Thanks! Setting checkin-needed to get this landed for us...

Comment 5

[akshitha shetty]

Great! Thanks

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2bb36fb5ead
Replace promiseWaitForEvent in browser_tab_dragdrop2.js with BrowserTestUtils.waitForEvent. r=johannh

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e2bb36fb5ead