1530281 - Replace promiseWaitForEvent in browser_typeAheadFind.js with BrowserTestUtils.waitForEvent

Status: RESOLVED FIXED

(Firefox :: General, enhancement, P5)

Description

[Johann Hofmann [:johannh]]

This is a good first bug for newcomers to Firefox development.

promiseWaitForEvent in the browser_typeAheadFind.js test file can be replaced by the BrowserTestUtils.waitForEvent utility function.

The code in question is here: https://searchfox.org/mozilla-central/rev/dc0adc07db3df9431a0876156f50c65d580010cb/browser/base/content/test/general/browser_typeAheadFind.js#15

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://developer.mozilla.org/en-US/docs/Introduction.

You can run this test with the ./mach mochitest command:

./mach mochitest browser/base/content/test/general/browser_typeAheadFind.js

Please leave a comment if you would like to be assigned to this bug and feel free to ask questions here or via IRC if you're stuck.

Comment 1

[Aashna]

Hey, can I take up this issue?

Comment 2

[Johann Hofmann [:johannh]]

Hi Aashna, I intended these bugs as introductory bugs to have an easy task while setting up your build environment.

Seeing that you already took bug 1530282, I would prefer to reserve this for someone else, if that's okay for you.

Thanks!

Comment 3

[mariahajmal]

Hi, I would like to contribute on this. Can you please assign it to me?

Comment 4

[Johann Hofmann [:johannh]]

Hi mariahajmal, I assigned you to bug 1530285, it would be great if you could focus on that one. Thanks!

Comment 5

[Shivani Sehgal]

Hi, I am an Outreachy applicant. I would like to work on this bug.

Comment 6

[Johann Hofmann [:johannh]]

It's yours, thanks! Let me know if you need any help.

Comment 7

[Shivani Sehgal]

Thanks! I'm working on it. I'm trying to build firefox locally. It seems like I need to upgrade to Mac OS 10.13 to run Xcode. Currently, I have Mac OS 10.12.6. I just want to make sure I'm on the right track. Please let me know if this upgrade is redundant.

Comment 8

[Johann Hofmann [:johannh]]

While you need to have XCode and the Command Line Utils installed to compile Firefox, you don't necessarily need XCode to modify the source code (though you can use it if you like). I'm not 100% sure about this, but I thought 10.12 would still be supported. Maybe I'm wrong, though. Upgrading certainly won't hurt, AFAICT.

Comment 9

[Shivani Sehgal]

I installed an older version of XCode and it works fine.
Now I'm stuck with some other error. When I ran "python bootstrap.py" in the terminal. I chose "Firefox for Desktop" version. After answering a bunch of question I got this error:

"Installing Stylo and NodeJS packages requires a checkout of mozilla-central.
Once you have such a checkout, please re-run ./mach bootstrap from the
checkout directory."

I tried googling it. The first link said that I need to "disabled the alias 'log = log -G' ". I'm not sure what this means. Please guide me.

Also, I have figured out the bug. Once I'm able to build firefox locally, I'll test it and submit the patch asap.

Comment 10

[Shivani Sehgal]

(In reply to Johann Hofmann [:johannh] from comment #8)

Sorry to bother you with these errors. I'm new to mozilla, I hope you understand.
I was able to resolve the error mentioned in the previous comment. I got this message: "Your system should be ready to build Firefox for Desktop!"

I'm trying to build with "./mach build" command. I got the following error.

0:02.72 ERROR: Only clang/llvm 3.9 or newer is supported.
0:02.76 *** Fix above errors and then restart with "./mach build"
0:02.76 make: *** [configure] Error 1

I checked the version.

VIKASs-MacBook-Air:firefox vikas$ clang -v
Apple LLVM version 8.0.0 (clang-800.0.42.1)
Target: x86_64-apple-darwin16.7.0
Thread model: posix

Can you please guide me on this?
Please point me to the IRC channel for this project also.

Comment 11

[Shivani Sehgal]

Hello @Johann! I was able to resolve my doubts on the #introduction channel on IRC. I have made the changes in the code and tested it. I got the following results. Please let me know if this looks good.

Browser Chrome Test Summary
Passed: 2
Failed: 0
Todo: 0
Mode: e10s
*** End BrowserChrome Test Results ***
0:10.59 INFO Buffered messages finished
0:10.59 SUITE_END
0:10.59
Overall Summary

mochitest-browser

Ran 3 checks (2 subtests, 1 tests)
Expected results: 3
OK

Comment 12

[Shivani Sehgal]

I have submitted a diff and put it up for review. I have made you the reviewer. I hope it is fine. Please let me know if anything else needs to be done.

Link to the phabricator: https://phabricator.services.mozilla.com/D21855

Comment 13

[Shivani Sehgal]

Attachment: Bug 1530281

Replace promiseWaitForEvent in browser_typeAheadFind.js with BrowserTestUtils.waitForEvent

Comment 14

[Farheen]

Hi Johann,

Hi April,

I am an Outreachy applicant. I am very excited to contribute to the project. My expertise are in HTML/CSS and basics of Javascript. Can you please find a bug for me ? I want to learn these skills further.

Comment 15

[Shivani Sehgal]

Attachment: Bug 1530281 - Replace promiseWaitForEvent in browser_typeAheadFind.js with BrowserTestUtils.waitForEvent. r=johannh

Comment 16

[Johann Hofmann [:johannh]]

Let's get this landed!

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2edf8ec64d18
Replace promiseWaitForEvent in browser_typeAheadFind.js with BrowserTestUtils.waitForEvent. r=johannh

Comment 18

[Shivani Sehgal]

(In reply to Johann Hofmann [:johannh] from comment #16)

Let's get this landed!

Is there anything else I need to do to get this change merged?
Should I use the Phabricator link to record my contribution?
Also Please let me know how else can I contribute? It would be great if you could point me to any unassigned bugs.
Thank you!

Comment 19

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/2edf8ec64d18