1530283 - Replace promiseWaitForEvent in waitForNewTabEvent with BrowserTestUtils.waitForEvent

Status: RESOLVED FIXED

Description

[Johann Hofmann [:johannh] (Away until July 3rd)]

This is a good first bug for newcomers to Firefox development.

promiseWaitForEvent usage in the waitForNewTabEvent test function can be replaced by the BrowserTestUtils.waitForEvent utility function.

The code in question is here: https://searchfox.org/mozilla-central/rev/dc0adc07db3df9431a0876156f50c65d580010cb/browser/base/content/test/general/head.js#395

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://developer.mozilla.org/en-US/docs/Introduction.

This is only used in browser_testOpenNewRemoteTabsFromNonRemoteBrowsers.js, so you should run this test after making your changes, with the ./mach mochitest command:

./mach mochitest browser/base/content/test/general/browser_testOpenNewRemoteTabsFromNonRemoteBrowsers.js

Please leave a comment if you would like to be assigned to this bug and feel free to ask questions here or via IRC if you're stuck.

Comment 1

[mariahajmal]

Hi, I would like to contribute on this. Can you please assign it to me?

Comment 2

[Johann Hofmann [:johannh] (Away until July 3rd)]

Hi mariahajmal, I assigned you to bug 1530285, it would be great if you could focus on that one. Thanks!

Comment 3

[Rizwan Syed]

Hey Johann, My name is Riz, and I am an Outreachy applicant based in London. I am keen to contribute to this. May you please assign it to me?

Comment 4

[Johann Hofmann [:johannh] (Away until July 3rd)]

Absolutely, thank you, Riz. Let me know if you need any help.

Comment 5

[Rizwan Syed]

Thanks :)

Comment 6

[Rizwan Syed]

Attachment: Bug 1530283 replaced promiseWaitForEvent usage in the waitForNewTabEvent test function with the BrowserTestUtils.waitForEvent utility function r=reviewers

Replaced promiseWaitForEvent usage in the waitForNewTabEvent test function with the BrowserTestUtils.waitForEvent utility function r=reviewers

Comment 7

[Johann Hofmann [:johannh] (Away until July 3rd)]

Setting checkin-needed to get this landed...

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8dc3d4283b0c
replaced promiseWaitForEvent usage in the waitForNewTabEvent test function with the BrowserTestUtils.waitForEvent utility function r=johannh

Comment 9

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/8dc3d4283b0c