Replace promiseWaitForEvent in waitForNewTabEvent with BrowserTestUtils.waitForEvent

RESOLVED FIXED in Firefox 67

Status

()

enhancement
P5
normal
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: johannh, Assigned: jk025523, Mentored)

Tracking

({good-first-bug})

unspecified
Firefox 67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

This is a good first bug for newcomers to Firefox development.

promiseWaitForEvent usage in the waitForNewTabEvent test function can be replaced by the BrowserTestUtils.waitForEvent utility function.

The code in question is here: https://searchfox.org/mozilla-central/rev/dc0adc07db3df9431a0876156f50c65d580010cb/browser/base/content/test/general/head.js#395

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://developer.mozilla.org/en-US/docs/Introduction.

This is only used in browser_testOpenNewRemoteTabsFromNonRemoteBrowsers.js, so you should run this test after making your changes, with the ./mach mochitest command:

./mach mochitest browser/base/content/test/general/browser_testOpenNewRemoteTabsFromNonRemoteBrowsers.js

Please leave a comment if you would like to be assigned to this bug and feel free to ask questions here or via IRC if you're stuck.

Comment 1

4 months ago

Hi, I would like to contribute on this. Can you please assign it to me?

Hi mariahajmal, I assigned you to bug 1530285, it would be great if you could focus on that one. Thanks!

Assignee

Comment 3

4 months ago

Hey Johann, My name is Riz, and I am an Outreachy applicant based in London. I am keen to contribute to this. May you please assign it to me?

Absolutely, thank you, Riz. Let me know if you need any help.

Assignee: nobody → jk025523
Status: NEW → ASSIGNED
Assignee

Comment 5

4 months ago

Thanks :)

Assignee

Comment 6

4 months ago

Replaced promiseWaitForEvent usage in the waitForNewTabEvent test function with the BrowserTestUtils.waitForEvent utility function r=reviewers

Setting checkin-needed to get this landed...

Keywords: checkin-needed

Comment 8

4 months ago

Pushed by rgurzau@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8dc3d4283b0c
replaced promiseWaitForEvent usage in the waitForNewTabEvent test function with the BrowserTestUtils.waitForEvent utility function r=johannh

Keywords: checkin-needed

Comment 9

4 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.