Replace promiseWaitForEvent in waitForNewTabEvent with BrowserTestUtils.waitForEvent
Categories
(Firefox :: General, enhancement, P5)
Tracking
()
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: johannh, Assigned: jk025523, Mentored)
References
Details
(Keywords: good-first-bug)
Attachments
(1 file)
This is a good first bug for newcomers to Firefox development.
promiseWaitForEvent usage in the waitForNewTabEvent test function can be replaced by the BrowserTestUtils.waitForEvent utility function.
The code in question is here: https://searchfox.org/mozilla-central/rev/dc0adc07db3df9431a0876156f50c65d580010cb/browser/base/content/test/general/head.js#395
For instructions on how to get your local build of Firefox up and running and submit your patch, see https://developer.mozilla.org/en-US/docs/Introduction.
This is only used in browser_testOpenNewRemoteTabsFromNonRemoteBrowsers.js, so you should run this test after making your changes, with the ./mach mochitest
command:
./mach mochitest browser/base/content/test/general/browser_testOpenNewRemoteTabsFromNonRemoteBrowsers.js
Please leave a comment if you would like to be assigned to this bug and feel free to ask questions here or via IRC if you're stuck.
Comment 1•2 years ago
|
||
Hi, I would like to contribute on this. Can you please assign it to me?
Reporter | ||
Comment 2•2 years ago
|
||
Hi mariahajmal, I assigned you to bug 1530285, it would be great if you could focus on that one. Thanks!
Assignee | ||
Comment 3•2 years ago
|
||
Hey Johann, My name is Riz, and I am an Outreachy applicant based in London. I am keen to contribute to this. May you please assign it to me?
Reporter | ||
Comment 4•2 years ago
|
||
Absolutely, thank you, Riz. Let me know if you need any help.
Assignee | ||
Comment 5•2 years ago
|
||
Thanks :)
Assignee | ||
Comment 6•2 years ago
|
||
Replaced promiseWaitForEvent usage in the waitForNewTabEvent test function with the BrowserTestUtils.waitForEvent utility function r=reviewers
Updated•2 years ago
|
Reporter | ||
Comment 7•2 years ago
|
||
Setting checkin-needed
to get this landed...
Pushed by rgurzau@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8dc3d4283b0c
replaced promiseWaitForEvent usage in the waitForNewTabEvent test function with the BrowserTestUtils.waitForEvent utility function r=johannh
Comment 9•2 years ago
|
||
bugherder |
Description
•