On second look, I don't think this comment is really right. Casting out-of-range value to signed isn't UB, it's *implementation-defined*, which isn't necessarily unsafe. But it's easy enough to make this all be wholly-defined operations -- cast to unsigned type is defined as modulus, WrapToSigned was written carefully to avoid any UB itself -- so we should just do that.
Attachment #9046451 - Flags: review?(nfroyd)
Assignee: nobody → jwalden
Status: NEW → ASSIGNED
Attachment #9046451 - Flags: review?(nfroyd) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/5ea654f841a4 Be more careful about converting int32_t to DataView element type. r=froydnj
You need to log in before you can comment on or make changes to this bug.