1530314 - Change "good signed message" icon to use a green seal, not a red seal

Status: RESOLVED FIXED

(MailNews Core :: Security: S/MIME, defect)

Description

[Kai Engert (:KaiE:)]

Today, the icons used for
"message with good digital signature"
and
"message with bad digital signature"
both use a letter icon, together with "something in red color".

Good uses a small red circle in the middle of the letter.
Bad uses a larger red circle with a white X inside it.

Is this sufficiently different to allow users to notice?

If a user is able to see color, and relies on seeing the expected color, might the user fail to notice the difference?

Suggestion:

Change the "good digital signature" icon to use a green circle for the seal (not red).

Thoughts?

Comment 1

[Kai Engert (:KaiE:)]

Attachment: hdrSignNotOk.png - bad signature

Comment 2

[Kai Engert (:KaiE:)]

Attachment: hdrSignOk.png - current good signature

Comment 3

[Alessandro Castellani [:aleca]]

Indeed, this is odd using a red seal, even if "historically correct", it doesn't communicate trust and success to the user.
Can I see it in context with a screenshot?
I wonder if we could improve them even more by using our Photon icons.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: signedMessage.png

This is how a signed and encrypted message looks. Not really Photonish icons.

Comment 5

[Kai Engert (:KaiE:)]

Wow, we forgot about this for 6 months...

I don't know if anyone will have time to work out new icons, so I suggest to start with a minimal first step. I've used an image editor to replace the red color with green color (including the shades).

I'll upload the new icons and a patch.

Comment 6

[Kai Engert (:KaiE:)]

Attachment: replacement - green - hdrSignOk.png

Comment 7

[Kai Engert (:KaiE:)]

Attachment: green - sbSignOk.png

We also have smaller icons which might be shown on a status bar.

Comment 8

[Kai Engert (:KaiE:)]

Attachment: Bug 1530314 - Use green, not red, for the seal color on the letter for good digital signatures. r=aleca

Comment 9

[Richard Marti (:Paenglab)]

Attachment: hdrSignOk.png

The same icon but PNGoptimised - size 36% of your icon.

Comment 10

[Richard Marti (:Paenglab)]

Attachment: sbSignOk.png

The same icon but PNGoptimised - size 27% of your icon.

Comment 11

[Kai Engert (:KaiE:)]

Richard, we have 6 icons in total. How did you process those icons?

Comment 12

[Kai Engert (:KaiE:)]

(The reason is that we have separate files for linux/mac/win)

Comment 13

[Richard Marti (:Paenglab)]

I think we should unify these file, but this could do Alessandro later (this is why I hate Phab because the conversation there isn't visible here). I'm using PNGOptimizer http://psydk.org/pngoptimizer. It's available for Linux and Windows.

Comment 14

[Kai Engert (:KaiE:)]

I'll push the patch that Alessandro reviewed, and file a separate bug to get the icons unified and compressed.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/88ed189e6360
Change "good signed message" icon to use a green seal, not a red seal. r=aleca