Update IANA Language Subtag Registry data to version 2018-02-20

RESOLVED FIXED in Firefox 67

Status

()

enhancement
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: anba, Assigned: anba)

Tracking

Trunk
mozilla67
Points:
---

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Assignee

Comment 1

4 months ago
Posted patch bug1530320.patch (obsolete) — Splinter Review

hy-arevela and hy-arevmda now both need to be special-cased similar to the existing special case for ja-Latn-hepburn-heploc.

The updated registry entries for both language tags are:

%%
Type: variant
Subtag: arevela
Description: Eastern Armenian
Added: 2006-09-18
Deprecated: 2018-03-24
Prefix: hy
Comments: Preferred tag is hy
%%
Type: variant
Subtag: arevmda
Description: Western Armenian
Added: 2006-09-18
Deprecated: 2018-03-24
Prefix: hy
Comments: Preferred tag is hyw
%%

So there's no longer a Preferred-Value field and instead the preferred tag is only mentioned in the Comments field.

Attachment #9046395 - Flags: review?(jwalden)
Comment on attachment 9046395 [details] [diff] [review]
bug1530320.patch

Review of attachment 9046395 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/builtin/intl/make_intl_data.py
@@ +106,5 @@
>      variantMappings = {}
>      extlangMappings = {}
>      extlangSubtags = []
>  
> +    # List of language tags which require special handling.

Set?

@@ +211,5 @@
> +    for elem in knownSpecialCases:
> +        tag = "{}-{}".format(elem.Prefix, elem.Subtag)
> +        assert elem.Type == "variant", "Unexpected non-variant special case"
> +        assert tag in variantMappings, "{} not found in variant mappings".format(tag)
> +        assert variantMappings[tag] == knownSpecialCases[elem],\

Space before line continuation?
Attachment #9046395 - Flags: review?(jwalden) → review+
Assignee

Comment 3

4 months ago
Posted patch bug1530320.patch (obsolete) — Splinter Review
  • Changed "List" -> "Set" per review comments.
  • Changed line indentation per flake error...
Attachment #9046395 - Attachment is obsolete: true
Attachment #9047111 - Flags: review+
Assignee

Comment 4

4 months ago

(In reply to Jeff Walden [:Waldo] from comment #2)

@@ +211,5 @@

  • for elem in knownSpecialCases:
  •    tag = "{}-{}".format(elem.Prefix, elem.Subtag)
    
  •    assert elem.Type == "variant", "Unexpected non-variant special case"
    
  •    assert tag in variantMappings, "{} not found in variant mappings".format(tag)
    
  •    assert variantMappings[tag] == knownSpecialCases[elem],\
    

Space before line continuation?

Do you mean , \ instead of ,\ or adding/removing space somewhere else? (\, without space between the comma and the line continuation is already used at three other places in make_intl_data.py.)

(In reply to André Bargull [:anba] from comment #4)

Do you mean , \ instead of ,\

Yes, that.

(\, without space between the comma and the line continuation is already used at three other places in make_intl_data.py.)

Ugh, that's terrible and should change. Whywhywhywhywhy would anyone ever do it that way...

Assignee

Comment 6

4 months ago

(In reply to Jeff Walden [:Waldo] from comment #5)

(\, without space between the comma and the line continuation is already used at three other places in make_intl_data.py.)

Ugh, that's terrible and should change. Whywhywhywhywhy would anyone ever do it that way...

Hmm, I just blame it on the reviewer who allowed me to write it that way in the first place. ducks away :-D

Assignee

Comment 7

4 months ago

Updated to add whitespace between ',' and the line continuation.

Attachment #9047111 - Attachment is obsolete: true
Attachment #9047170 - Flags: review+
Assignee

Updated

4 months ago
Keywords: checkin-needed

Comment 8

4 months ago

Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/75af9e205c28
Update IANA language subtag registry data to version 2019-02-20. r=Waldo

Keywords: checkin-needed

Comment 9

4 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.