1530320 - Update IANA Language Subtag Registry data to version 2018-02-20

Status: RESOLVED FIXED

(Core :: JavaScript: Internationalization API, enhancement)

Description

[André Bargull [:anba]]

Doesn't add anything new, but instead only fixes invalid data within the registry.

• https://mailarchive.ietf.org/arch/msg/ietf-languages/_aEctO0A5ResjTfOEGB2VryWhi4
• https://mailarchive.ietf.org/arch/msg/ietf-languages/_uxUBEppvHL1Xkq1JKWb2lpk_Fo

Comment 1

[André Bargull [:anba]]

Attachment: bug1530320.patch

hy-arevela and hy-arevmda now both need to be special-cased similar to the existing special case for ja-Latn-hepburn-heploc.

The updated registry entries for both language tags are:

%%
Type: variant
Subtag: arevela
Description: Eastern Armenian
Added: 2006-09-18
Deprecated: 2018-03-24
Prefix: hy
Comments: Preferred tag is hy
%%
Type: variant
Subtag: arevmda
Description: Western Armenian
Added: 2006-09-18
Deprecated: 2018-03-24
Prefix: hy
Comments: Preferred tag is hyw
%%

So there's no longer a Preferred-Value field and instead the preferred tag is only mentioned in the Comments field.

Comment 2

[Jeff Walden [:Waldo]]

Comment on attachment 9046395 [details] [diff] [review]
bug1530320.patch

Review of attachment 9046395 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/builtin/intl/make_intl_data.py
@@ +106,5 @@
>      variantMappings = {}
>      extlangMappings = {}
>      extlangSubtags = []
>  
> +    # List of language tags which require special handling.

Set?

@@ +211,5 @@
> +    for elem in knownSpecialCases:
> +        tag = "{}-{}".format(elem.Prefix, elem.Subtag)
> +        assert elem.Type == "variant", "Unexpected non-variant special case"
> +        assert tag in variantMappings, "{} not found in variant mappings".format(tag)
> +        assert variantMappings[tag] == knownSpecialCases[elem],\

Space before line continuation?

Comment 3

[André Bargull [:anba]]

Attachment: bug1530320.patch

• Changed "List" -> "Set" per review comments.
• Changed line indentation per flake error...

Comment 4

[André Bargull [:anba]]

(In reply to Jeff Walden [:Waldo] from comment #2)

@@ +211,5 @@

• for elem in knownSpecialCases:

•    tag = "{}-{}".format(elem.Prefix, elem.Subtag)
  

•    assert elem.Type == "variant", "Unexpected non-variant special case"
  

•    assert tag in variantMappings, "{} not found in variant mappings".format(tag)
  

•    assert variantMappings[tag] == knownSpecialCases[elem],\
  

Space before line continuation?

Do you mean , \ instead of ,\ or adding/removing space somewhere else? (\, without space between the comma and the line continuation is already used at three other places in make_intl_data.py.)

Comment 5

[Jeff Walden [:Waldo]]

(In reply to André Bargull [:anba] from comment #4)

Do you mean , \ instead of ,\

Yes, that.

(\, without space between the comma and the line continuation is already used at three other places in make_intl_data.py.)

Ugh, that's terrible and should change. Whywhywhywhywhy would anyone ever do it that way...

Comment 6

[André Bargull [:anba]]

(In reply to Jeff Walden [:Waldo] from comment #5)

(\, without space between the comma and the line continuation is already used at three other places in make_intl_data.py.)

Ugh, that's terrible and should change. Whywhywhywhywhy would anyone ever do it that way...

Hmm, I just blame it on the reviewer who allowed me to write it that way in the first place. ducks away :-D

Comment 7

[André Bargull [:anba]]

Attachment: bug1530320.patch

Updated to add whitespace between ',' and the line continuation.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/75af9e205c28
Update IANA language subtag registry data to version 2019-02-20. r=Waldo

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/75af9e205c28