1530348 - Unfork aboutNetError.{xhtml,css}

Status: RESOLVED FIXED

(Firefox :: Security, enhancement, P2)

Description

[Johann Hofmann [:johannh]]

New cert errors is shipping in 66 so we can remove the old aboutNetError files and make the new aboutNetError-new files the new default instead.

https://searchfox.org/mozilla-central/search?q=aboutNetError-new&case=false&regexp=false&path=

Out of caution we should probably target 68.

Comment 1

[Divya Baid]

Hi, I would like to contribute to this. Can you please assign it to me?

Comment 2

[Johann Hofmann [:johannh]]

(In reply to Divya Baid from comment #1)

Hi, I would like to contribute to this. Can you please assign it to me?

Hi, I don't think this bug can be taken up at this point, sorry and thanks for your interest.

Comment 3

[Johann Hofmann [:johannh]]

Attachment: Bug 1530348 - Unfork aboutNetError.{xhtml,css}. r=nhnt11

The larger changesets in this patch are simply moving code from one file into the other with hg mv.

Comment 4

[Johann Hofmann [:johannh]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=599ff288336e1dd0f2db3cc1054747aaf7b4b57a

Comment 5

[(inactive) Nihanth Subramanya [:nhnt11]]

Johann, if you can provide evidence that the set of changes made in the patch covers everything needed to unfork, that would be great. I think just documenting them in this bug for posterity would be fine. (like, "updated AboutRedirector", "unforked CSS", etc - a series of steps).

Thank you for the patch!

Comment 6

[Johann Hofmann [:johannh]]

(In reply to Nihanth Subramanya [:nhnt11] from comment #5)

Johann, if you can provide evidence that the set of changes made in the patch covers everything needed to unfork, that would be great. I think just documenting them in this bug for posterity would be fine. (like, "updated AboutRedirector", "unforked CSS", etc - a series of steps).

Thank you for the patch!

I'm not entirely sure what you mean, isn't that what the patch diff does? :)

Comment 7

[Johann Hofmann [:johannh]]

Added a couple of lines to the commit message.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46b2369b332c
Unfork aboutNetError.{xhtml,css}. r=nhnt11

Comment 9

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/46b2369b332c