Unfork aboutNetError.{xhtml,css}

RESOLVED FIXED in Firefox 68

Status

()

enhancement
P2
normal
RESOLVED FIXED
4 months ago
22 days ago

People

(Reporter: johannh, Assigned: johannh)

Tracking

(Blocks 1 bug)

unspecified
Firefox 68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(1 attachment)

New cert errors is shipping in 66 so we can remove the old aboutNetError files and make the new aboutNetError-new files the new default instead.

https://searchfox.org/mozilla-central/search?q=aboutNetError-new&case=false&regexp=false&path=

Out of caution we should probably target 68.

Comment 1

4 months ago

Hi, I would like to contribute to this. Can you please assign it to me?

(In reply to Divya Baid from comment #1)

Hi, I would like to contribute to this. Can you please assign it to me?

Hi, I don't think this bug can be taken up at this point, sorry and thanks for your interest.

Assignee: nobody → jhofmann
Status: NEW → ASSIGNED

The larger changesets in this patch are simply moving code from one file into the other with hg mv.

Johann, if you can provide evidence that the set of changes made in the patch covers everything needed to unfork, that would be great. I think just documenting them in this bug for posterity would be fine. (like, "updated AboutRedirector", "unforked CSS", etc - a series of steps).

Thank you for the patch!

Flags: needinfo?(jhofmann)

(In reply to Nihanth Subramanya [:nhnt11] from comment #5)

Johann, if you can provide evidence that the set of changes made in the patch covers everything needed to unfork, that would be great. I think just documenting them in this bug for posterity would be fine. (like, "updated AboutRedirector", "unforked CSS", etc - a series of steps).

Thank you for the patch!

I'm not entirely sure what you mean, isn't that what the patch diff does? :)

Flags: needinfo?(jhofmann) → needinfo?(nhnt11)

Added a couple of lines to the commit message.

Flags: needinfo?(nhnt11)

Comment 8

3 months ago
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/46b2369b332c
Unfork aboutNetError.{xhtml,css}. r=nhnt11

Comment 9

3 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68

Updated

2 months ago
Regressions: 1547695

Updated

23 days ago
Regressions: 1556584
You need to log in before you can comment on or make changes to this bug.