Open Bug 1530458 Opened 4 years ago Updated 6 months ago

Ctrl+1 zooms in Czech keyboard layout

Categories

(Core :: DOM: UI Events & Focus Handling, defect, P3)

defect

Tracking

()

People

(Reporter: vjirovsky, Unassigned)

References

(Depends on 1 open bug)

Details

(Whiteboard: [key hell])

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0

Steps to reproduce:

  1. switch keyboard layout to Czech keyboard
  2. open two tabs
  3. go to Tab #2
  4. use keyboard shortcut Ctrl+1

Actual results:

Firefox will zoom in current page

Expected results:

Firefox should switch to Tab #1 (same as in English keyboard layout)

Component: Untriaged → cs / Czech
Product: Firefox → Mozilla Localizations
Version: 65 Branch → unspecified

(In reply to vjirovsky from comment #0)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0

Are you using Firefox in Czech or English?

I think this is about the Czech keyboard layout, and nothing that can be fixed in the localization.
https://hg.mozilla.org/l10n-central/cs/file/default/browser/chrome/browser/browser.dtd#l752

Flags: needinfo?(vjirovsky)

(In reply to Francesco Lodolo [:flod] from comment #1)

Are you using Firefox in Czech or English?

In Czech

I think this is about the Czech keyboard layout, and nothing that can be fixed in the localization.
https://hg.mozilla.org/l10n-central/cs/file/default/browser/chrome/browser/browser.dtd#l752

Google Chrome or Microsoft Edge has expected behavior in Czech keyboard layout;and what I remember, also Firefox had same behavior in the past

Flags: needinfo?(vjirovsky)

To clarify, I'm not saying it's not a bug, just that it's not related to the localization.

@Michal
Can you reproduce this? It would be great to check if it happens with an en-US build, and if we can track down when it started.

Flags: needinfo?(mstanke)

Thank you for the report.

I have briefly checked with Firefox beta (cs l10n) Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:66.0) Gecko/20100101 Firefox/66.0 on MacBook (EN system, EN keyboard switched to CZ layout) and it all seems to work as expected. When I press Cmd+1, Firefox switches to the first tab.

I am not sure how the system can be involved, so I will test later on my Fedora (CZ system) and I will try to borrow some Windows 7 too. Keeping NI on me. Unfortunately Windows 10 machine is currently unreachable for me.

@vjirovsky
Before I get to test on other platforms, can you please give it a quick try with a fresh Firefox profile? Your data and settings will stay safely in the current default profile, which you can get back to after the test.

Flags: needinfo?(vjirovsky)

Thanks,

i am not sure about differences between EN/CZ keyboards vs. EN/CZ layout, but I do have Windows 10 in English with OS's additional Czech language support and keyboard Czech (QWERTZ).

I also performed test with fresh Firefox profile on another machine with Windows 10 in Czech with Czech (QWERTZ) keyboard - same unexpected behavior.

Can I gather you some other data to reproduce bug?

Flags: needinfo?(vjirovsky)

I can reproduce in Nightly (cs l10n) Mozilla/5.0 (X11; Linux x86_64; rv:67.0) Gecko/20100101 Firefox/67.0 on Fedora 29 (CZ system, CZ keyboard). Let me try mozregression if it's reproducible there too.

Flags: needinfo?(mstanke)

(In reply to Michal Stanke (Mozilla.cz) [:MikkCZ][:mstanke] (use needinfo) from comment #6)

I can reproduce in Nightly (cs l10n) Mozilla/5.0 (X11; Linux x86_64; rv:67.0) Gecko/20100101 Firefox/67.0 on Fedora 29 (CZ system, CZ keyboard). Let me try mozregression if it's reproducible there too.

Can you start by checking if it happens on English + cs layout?

Back to the trees - on Linux the modifier key is Alt (according to this article). Which works for me correctly in my Nightly (cs l10n) as well with mozregression --good 2017-01-01 (en-US l10n) with both CZ and EN-US layouts.

I have quickly borrowed a Windows 7 machine from my friend with Firefox 65.0.1 release (all Czech) and... only Ctrl+Shift+1 or Ctrl+1, where 1 is on the numerical keypad. Ctrl+1 with 1 on the upper keyboard line (without any modifier it is actually +) truly does zoom-in.

But I cannot run mozregression on that machine to find any potential window where the change happened. So if anyone is willing to find it, please follow:

  1. Have a CZ keyboard layout set in your system.
  2. Install mozregression.
  3. Try to run it e.g. for the last year by mozregression --good 2018-01-01.
  4. For each revision ensure that the CZ keyboard layout is still active when the opened window is focused.
  5. Paste the result here.

Anyway as :flod pointed out, this is likely not l10n related.

Not sure if core:: or firefox::, but this sounds like keyboard navigation.

Status: UNCONFIRMED → NEW
Component: cs / Czech → Keyboard: Navigation
Ever confirmed: true
Product: Mozilla Localizations → Core

(In reply to Michal Stanke (Mozilla.cz) [:MikkCZ][:mstanke] (use needinfo) from comment #8)

Back to the trees - on Linux the modifier key is Alt (according to this article). Which works for me correctly in my Nightly (cs l10n) as well with mozregression --good 2017-01-01 (en-US l10n) with both CZ and EN-US layouts.

I have quickly borrowed a Windows 7 machine from my friend with Firefox 65.0.1 release (all Czech) and... only Ctrl+Shift+1 or Ctrl+1, where 1 is on the numerical keypad. Ctrl+1 with 1 on the upper keyboard line (without any modifier it is actually +) truly does zoom-in.

But I cannot run mozregression on that machine to find any potential window where the change happened. So if anyone is willing to find it, please follow:

  1. Have a CZ keyboard layout set in your system.
  2. Install mozregression.
  3. Try to run it e.g. for the last year by mozregression --good 2018-01-01.
  4. For each revision ensure that the CZ keyboard layout is still active when the opened window is focused.
  5. Paste the result here.

Anyway as :flod pointed out, this is likely not l10n related.

Hi :vjirovsky,
Thanks for reporting this issue. Do you think you can help us get a regression window that would be a huge help to make this forward? Thanks again!

Flags: needinfo?(vjirovsky)

Hello,
I tested many builds (by mozregression tool) on Windows 10 until 2010-06-23, but all of them contains this bug.
Best

Flags: needinfo?(vjirovsky)

Hello,
This issue is reproducible back to Firefox 4.0, this is not a regression.

Priority: -- → P3
Whiteboard: [key hell]

Ah, Digit1 key produces + and 1...

I have no idea how to fix this bug ideally. If we prefer Ctrl++ as Ctrl+1, Ctrl+Shift++ as also not handled as Ctrl++. So, without numpad, Czech users cannot zoom-in web contents with keyboard. Is it okay??

Flags: needinfo?(vjirovsky)

Personally I would vote for staying with the current behaviour, given the fact it works that for years (probably forever).

Note: I realized there is already some hack to reset zoom for Czech layout. Both Ctrl+é and Ctrl+Shift+é actually reset zoom (Shift+é -> 0, the same as Shift++ -> 1).

I would vote for changing this behaviour back to tab switching - a long time ago, it was changing tabs, but some update bringed this inconsistent behaviour (but you are right, is it there for years)..but it's really strange for user, that this button does different action after switching keyboard layout.

(Also, all the rest browsers have tab switching on Czech keyboard layout - I would prefer to be consistent in Mozzila UI)

Flags: needinfo?(vjirovsky)
Depends on: 57805
Component: Keyboard: Navigation → User events and focus handling

Still not fixed in 2022, FF 98.0.2... in MacOS (Monterey) with Czech keyboard layout, cmd+1 still zooms in instead of switching to first tab.

You need to log in before you can comment on or make changes to this bug.