Add support for arbitrary JSON to the schema validator

RESOLVED FIXED in Firefox 67

Status

()

enhancement
P1
normal
RESOLVED FIXED
4 months ago
3 months ago

People

(Reporter: mkaply, Assigned: mkaply)

Tracking

unspecified
Firefox 67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

4 months ago

In order to support chrome.storage.managed and other features, the policy engine needs to support arbitrary JSON in policies.

But on Windows, GPO can't do arbitrary JSON, so things will be specified as strings (same as Chrome).

So this new support will introduce a new type called JSON that either parses a string or uses the specified object.

    "addon@example.com": {
      "policy": "{\"url_list\": [\"mike.kaply.com\"]}"
    }

or

    "addon@example.com": {
      "policy": {
        "url_list": ["mike.kaply.com"]
      }
    }

Will both work for:

          "properties": {
            "policy" : {
              "type": ["JSON"]
            }
          }
Assignee

Updated

4 months ago
Blocks: 1230802

Comment 2

4 months ago
Pushed by mozilla@kaply.com:
https://hg.mozilla.org/integration/autoland/rev/43848f381d6c
Add support for JSON type in schema validator. r=Felipe

Comment 3

4 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67

Hi Mike,

This bug is under our beta triage radar. Is manual testing required for this bug?

Flags: qe-verify?
Flags: needinfo?(mozilla)
QA Contact: emil.ghitta
Assignee

Comment 5

3 months ago

This bug is under our beta triage radar. Is manual testing required for this bug?

Nope. We have automated testing to cover this. It's an internal thing.

Flags: needinfo?(mozilla)

Thank you for your answer. I will take out the flag for qe-verify ?

Flags: qe-verify?
You need to log in before you can comment on or make changes to this bug.