1530493 - mingw builds missing templated C++ overloads for secure string functions

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[(No longer employed by Mozilla) Aaron Klotz]

The Microsoft CRT provides template magic for its secure string functions (the ones named with the "_s" suffix) that allow the compiler to infer the size of the output buffer.

MinGW also provides these, but only when the _CRT_SECURE_CPP_OVERLOAD_SECURE_NAMES is defined. But that appears to be gated on MINGW_HAS_SECURE_API == 1, which appears to be dependent on mingw's configure settings?

I'm not 100% sure, but I'm leaning toward this being a configure issue on our build machines as opposed to something that we can fix in the build system.

ni? Jacek for information. I'll move components if we can't do anything about this in our build system.

Comment 1

[Jacek Caban]

Those overloaded functions should be enabled in our builds:
https://hg.mozilla.org/mozilla-central/file/tip/taskcluster/scripts/misc/build-clang-trunk-mingw.sh#l114

It's possible that something is missing or they are not used for some functions that should use them. What's the exact problem that you noticed?

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

(In reply to Jacek Caban from comment #1)

It's possible that something is missing or they are not used for some functions that should use them. What's the exact problem that you noticed?

https://bugzilla.mozilla.org/show_bug.cgi?id=1460433#c33

Comment 3

[Jacek Caban]

It's missing for _wcslwr_s, I sent a patch upstream.

Comment 4

[Jacek Caban]

I just pushed it to upstream repo. We just need to update used mingw-w64 now.

Comment 5

[(Away)]

Aaron's push also used _wmakepath_s, does that need an update too?

Comment 6

[Jacek Caban]

_wmakepath_s has overloads defined in wchar.h, but it's not duplicated in stdlib.h (and it probably should), so results may vary depending how it's used. We should probably get rid of this duplication like it's done in UCRT.

Comment 7

[Jacek Caban]

I pushed a patch to ensure that overloads are always defined. I also removed --enable-secure-api configure option and use of MINGW_HAS_SECURE_API macro to avoid future confusion. It's always enabled in mingw-w64 and we can remove it from our build script now.

Comment 8

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1530493 - Bump mingw-w64 version r?#build

This is needed to bring dispatherqueue.h in, which is needed for
an ANGLE upgrade.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d067e0360843
Bump mingw-w64 version r=froydnj

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d067e0360843