1530544 - Use consistent question style for prompt inside bootstrap and mercurial-setup

Status: RESOLVED FIXED

(Firefox Build System :: Bootstrap Configuration, enhancement, P5)

Description

[Tooru Fujisawa [:arai]]

Steps to reproduce:

1. ./mach bootstrap

Actual result:
there are at least 3 styles of questions in the prompt line

1. enumerate options and ask for number

Please choose the version of Firefox you want to build:
1. Firefox for Desktop Artifact Mode
2. Firefox for Desktop
3. GeckoView/Firefox for Android Artifact Mode
4. GeckoView/Firefox for Android
Your choice:

...

Would you like to run a configuration wizard to ensure Mercurial is
optimally configured?

  1. Yes
  2. No

Please enter your reply: 1

2. ask the actual question with "Yn" (in mercurial-setup)

Would you like to enable these history editing extensions (Yn)?
...
Would you like to enable the evolve extension? (Yn)
...
Enable logging of commands to help diagnose bugs and performance problems (Yn)
...
Would you like to activate clang-format (Yn)?
...
Would you like to activate format-source (Yn)?
...
Would you like to install the `hg smart-annotate` alias (Yn)?
...
Will you be submitting commits to Mozilla (Yn)?

3. long description with "Y/n"

Would you like to enable build system telemetry?

Mozilla collects data about local builds in order to make builds faster and
improve developer tooling. To learn more about the data we intend to collect
read here:
https://firefox-source-docs.mozilla.org/build/buildsystem/telemetry.html.

If you have questions, please ask in #build in irc.mozilla.org. If you would
like to opt out of data collection, select (N) at the prompt.

Your choice [Y/n]: n

Expected result:
Questions are asked in the consistent style.
especially the 3rd one is hard to follow.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1530544 - Use consistent question style for prompt inside bootstrap and mercurial-setup. r?glandium

Changed the following:

• Use (Yn) instead of [Y/n] to align with mercurial-setup that is using
  mercurial's ui class
• Use (Yn) prompt instead of int prompt where the options are Yes/No
• Remove empty lines around options to align with the first question
  about Firefox {Desktop,Mobile} {,non-}Artifact
• Move the question Would you like to enable build system telemetry?
  to the last line
• Use Your choice: propmt for int prompt to align with the first question

Depends on D23456

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/106a5731e7f4
Use consistent question style for prompt inside bootstrap and mercurial-setup. r=glandium

Comment 3

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/106a5731e7f4