Closed Bug 1530544 Opened 1 year ago Closed 1 year ago

Use consistent question style for prompt inside bootstrap and mercurial-setup

Categories

(Firefox Build System :: Bootstrap Configuration, enhancement, P5)

enhancement

Tracking

(firefox68 fixed)

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: arai, Assigned: arai)

Details

Attachments

(1 file)

Steps to reproduce:

  1. ./mach bootstrap

Actual result:
there are at least 3 styles of questions in the prompt line

  1. enumerate options and ask for number
Please choose the version of Firefox you want to build:
1. Firefox for Desktop Artifact Mode
2. Firefox for Desktop
3. GeckoView/Firefox for Android Artifact Mode
4. GeckoView/Firefox for Android
Your choice:

...

Would you like to run a configuration wizard to ensure Mercurial is
optimally configured?

  1. Yes
  2. No

Please enter your reply: 1
  1. ask the actual question with "Yn" (in mercurial-setup)
Would you like to enable these history editing extensions (Yn)?
...
Would you like to enable the evolve extension? (Yn)
...
Enable logging of commands to help diagnose bugs and performance problems (Yn)
...
Would you like to activate clang-format (Yn)?
...
Would you like to activate format-source (Yn)?
...
Would you like to install the `hg smart-annotate` alias (Yn)?
...
Will you be submitting commits to Mozilla (Yn)?
  1. long description with "Y/n"
Would you like to enable build system telemetry?

Mozilla collects data about local builds in order to make builds faster and
improve developer tooling. To learn more about the data we intend to collect
read here:
https://firefox-source-docs.mozilla.org/build/buildsystem/telemetry.html.

If you have questions, please ask in #build in irc.mozilla.org. If you would
like to opt out of data collection, select (N) at the prompt.

Your choice [Y/n]: n

Expected result:
Questions are asked in the consistent style.
especially the 3rd one is hard to follow.

Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED

Changed the following:

  • Use (Yn) instead of [Y/n] to align with mercurial-setup that is using
    mercurial's ui class
  • Use (Yn) prompt instead of int prompt where the options are Yes/No
  • Remove empty lines around options to align with the first question
    about Firefox {Desktop,Mobile} {,non-}Artifact
  • Move the question Would you like to enable build system telemetry?
    to the last line
  • Use Your choice: propmt for int prompt to align with the first question

Depends on D23456

Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/106a5731e7f4
Use consistent question style for prompt inside bootstrap and mercurial-setup. r=glandium
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.