1530549 - Debugger steps over when I click "Step out"

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Oriol Brufau [:Oriol]]

1. Run this code in the console:

(function() {
  (function(){debugger;})();
  var a = 1;
  a = 2;
  a = 3;
  a = 4;
})()

2. The debugger pauses at debugger.
3. Click "Step out", the debugger steps out and pauses at var a = 1
4. Click "Step out" again and again. The debugger steps over instead of exiting the function.

Regression window: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=dc1eb225488c72c73dabcce4179b94e3dd008ca9&tochange=f668df79d93b379add8c1019792e6fdef687506b

I suspect bug 1508314

Comment 1

[Logan Smyth [:loganfsmyth]]

You are correct about which bug introduced this, patch incoming.

Comment 2

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1530549 - Ensure that _clearSteppingHooks() runs _after_ we pause. r=jlast!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6579b451a352
Ensure that _clearSteppingHooks() runs _after_ we pause. r=jlast

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6579b451a352

Comment 5

[Julien Cristau [:jcristau]]

Please request uplift to beta when you get a chance.

Comment 6

[Logan Smyth [:loganfsmyth]]

Comment on attachment 9047095 [details]
Bug 1530549 - Ensure that _clearSteppingHooks() runs after we pause. r=jlast!

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: Bug 1508314
• User impact if declined: JS debugger's stepOut stepping feature will behave in unexpected ways that can be frustrating for users
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This change can only affect the call to this_clearSteppingHooks() since that is the only function call that happens between the new and old _state initialization location, and that is specifically the case that we are fixing by moving this line.
• String changes made/needed:

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9047095 [details]
Bug 1530549 - Ensure that _clearSteppingHooks() runs after we pause. r=jlast!

Fix limited to debugger, OK for beta uplift.

Comment 8

[Narcis Beleuzu [:NarcisB]]

There are conflicts while uplifting to beta.
warning: conflicts while merging devtools/server/actors/thread.js! (edit, then use 'hg resolve --mark')
warning: conflicts while merging devtools/server/tests/unit/xpcshell.ini! (edit, then use 'hg resolve --mark')

:loganfsmyth , can you please take a look?

Comment 9

[Logan Smyth [:loganfsmyth]]

Attachment: bug1530549.patch

Here is a new patch that won't conflict on 66, sorry about that.

Should I mark this one for beta now, or is the approval on the other one acceptable?

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-beta/rev/13616d2ad000