Closed Bug 1530571 Opened 9 months ago Closed 9 months ago

Update property_database.js and test_transitions_per_property.html for properties for the new scroll snap

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

64 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: hiro, Assigned: hiro)

References

(Blocks 1 open bug)

Details

Attachments

(6 files)

I did forget to update them in bug 1528639, bug 1528640 and bug 1528834.

This issue is not a problem for now since the relevant preference value is disabled, but will be a problem once we enable the pref on nightly.

Here is a try with the update and with enabling the pref.
https://treeherder.mozilla.org/#/jobs?repo=try&author=hikezoe%40mozilla.com

All test data came from scroll-snap-align-{valid,invalid}.html in wpt.

All test data came from wpt.

Depends on D21149

All test data came from wpt.

Depends on D21150

Otherwise the Trait for clamping negative animation value isn't generated thus
negative animating results are exposed in computed values.

Depends on D21152

Pushed by hikezoe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/079b60d94624
Add an entry for scroll-snap-align in property_database.js. r=emilio
https://hg.mozilla.org/integration/autoland/rev/6b22050aed7d
Add entries for for scroll-margin in property_database.js. r=emilio
https://hg.mozilla.org/integration/autoland/rev/aa2d2998a321
Add entries for for scroll-padding in property_database.js. r=emilio
https://hg.mozilla.org/integration/autoland/rev/6f9ea704602d
Add scroll-margin cases in test_transitions_per_property.html. ?boris r=boris
https://hg.mozilla.org/integration/autoland/rev/dc54c909289c
Explicitly specify animation_value_type for scroll-padding. r=boris
https://hg.mozilla.org/integration/autoland/rev/8f991ed45f90
Add scroll-padding cases in test_transitions_per_property.html. r=boris
You need to log in before you can comment on or make changes to this bug.