1530667 - browser_allow_process_switches_despite_related_browser.js times out locally

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Oriol Brufau [:Oriol]]

Not sure why treeherder is not complaining, but sometimes I want to run all tab tests locally with ./mach test browser/base/content/test/tabs/, and it's very annoying that browser_allow_process_switches_despite_related_browser.js times out.

The problem is that it does

const uriString = Services.io.newFileURI(dummyPage).spec;
let viewSourceBrowser = viewSourceTab.linkedBrowser;
let promiseLoad = BrowserTestUtils.browserLoaded(viewSourceBrowser, false, uriString);
BrowserTestUtils.loadURI(viewSourceBrowser, uriString);
let href = await promiseLoad;
is(href, uriString,

uriString is "file:///<moz-objdir>/_tests/testing/mochitest/browser/browser/base/content/test/tabs/dummy_page.html"

However, this is just a symlink which points to "file:///<moz-source>/browser/base/content/test/tabs/dummy_page.html"

That's the URL that it's loaded in viewSourceBrowser, so promiseLoad is never resolved. https://searchfox.org/mozilla-central/rev/b10ae6b7a50d176a813900cbe9dc18c85acd604b/testing/mochitest/BrowserTestUtils/BrowserTestUtils.jsm#345,360

And even if it would resolve, the is(href, uriString check at the end would fail.

dummyPage needs to be normalized.

Comment 1

[Oriol Brufau [:Oriol]]

Attachment: Bug 1530667 - Fix browser_allow_process_switches_despite_related_browser.js timeout. r=Gijs

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/faf6df595f9f
Fix browser_allow_process_switches_despite_related_browser.js timeout. r=Gijs

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/faf6df595f9f