1530684 - Update mitmproxy alternate server script to support WebSocket packages

Status: RESOLVED DUPLICATE of bug 1559110

(Testing :: Raptor, enhancement, P2)

Description

[Florin Strugariu [:Bebe]]

Currently we don't support this type of packages in mitmproxy

Because of this we can't replay https://hubs.mozilla.com/spES8RP/treasured-spirited-huddle

Comment 1

[Florin Strugariu [:Bebe]]

tested this locally:

I managed to get it to work with 4.0.4 and adding "--set stream_websockets=True",

note:
you need server replay for 4.0.4 with no websockets changes

see
https://docs.mitmproxy.org/stable/overview-features/#websockets
https://docs.mitmproxy.org/stable/concepts-options/

Comment 2

[Alexandru Ionescu (needinfo me) [:alexandrui]]

bebe, what's the status of this?

Comment 3

[Florin Strugariu [:Bebe]]

More investigation and development is required here

Comment 4

[Florin Strugariu [:Bebe]]

:tarek do you have any experience with this?

Comment 5

[Tarek Ziadé (:tarek)]

no, but I can probably help
In theory, mitmproxy should support the websocket protocol and do the right things.

what problem do you have?

Comment 6

[Florin Strugariu [:Bebe]]

Adding this here also from bug 1517799
From my research:

1. WPR does not support WebSockets. Tested using record/playback on http://websocket.org/echo.html
2. MitmProxy partially supports WebSockets:
   1. Out of the box when we use a recording containing websockets mitm crashes: https://github.com/mitmproxy/mitmproxy/issues/3564
   2. We can implement a plugin for websockets similar with alternate-server-replay but we might hit some other issues: https://github.com/mitmproxy/mitmproxy/issues/3396

Comment 7

[Florin Strugariu [:Bebe]]

:Tarek we need a similar replay algorithm as the one for http in alternate-server-replay

MITM already has some WebSoket addon integration:
https://docs.mitmproxy.org/stable/addons-events/