153073 - Find again multiple highlights on same screen

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Stephane Moureau]

If you make a Find Again (Cmd-G) and if the searched string is visible on the
same screen, the previous selected text remains highlighted (selected). If
several searched items are on the same screen, you'll get several highlighted text.

Comment 1

[saari (gone)]

minor, ->pinkerton

Comment 2

[Mike Pinkerton (not reading bugmail)]

this regressed at some point. it didn't happen when i first did the feature

Comment 3

[Simon Fraser [no longer active]]

Related to bug 155896? See also bug 153116 and bug 153572.

Comment 4

[Kathleen :Brade]

this is annoying
note: this only happens when it scrolls in response to the find next (if it
doesn't need to scroll, it renders correctly)

Comment 5

[Simon Fraser [no longer active]]

Attachment: Patch to redraw the entire view if scrolling with a dirty rect

Comment 6

[Simon Fraser [no longer active]]

Note that forcing a redraw before the scroll behaves incorrectly, because the
view manager has already repositioned the widget contents, so the wrong bits of
content redraw. This patch was the only way I could find to fix it.

I also note that despite the care taken to invalidate only the newly exposed
portion of the content, the entire view repaints after scrolling. I think it has
something to do with the views not being opaque.

Comment 7

[S Woodside]

I thought this was a feature before I saw this bug :-) Reference to emacs, which
does this as well, personally I like it.

Comment 8

[Brian Ryner (not reading)]

The patch here also fixes bug 157635.

Comment 9

[Simon Fraser [no longer active]]

Taking

Comment 10

[Simon Fraser [no longer active]]

I checked the patch in.