Closed Bug 1530730 Opened 1 year ago Closed 1 year ago

Debug assert in plane_split::polygon::Polygon::split_with_normal

Categories

(Core :: Graphics: WebRender, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: nical, Assigned: nical)

Details

Attachments

(1 file)

I'm hitting the assertion in split_with_normal that checks that t is within epsilon of the [0..1] range, after the intersection test.

t = 1.0000000000000009

I can reliably reproduce this on https://keithclark.co.uk/labs/css-fps/nojs/ with a debug build.

According to gdb, t is a f64, for which epsilon is 2.2204460492503131e-16_f64.
Unfortunately, with generic math code in rust it's a bit awkward to write "5 * epsilon" because you first have to craft that "5" unless we want to add another trait bound to the mix like From<f64>.

Pushed by nsilva@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/860d0c16a0fc
Update plane-split to 0.13.7. r=kvark
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Assignee: nobody → nical.bugzilla
You need to log in before you can comment on or make changes to this bug.