[RTL] Mirror the Pin/Unpin icons on the Page Actions menu

VERIFIED FIXED in Firefox 67

Status

()

defect
P5
normal
VERIFIED FIXED
4 months ago
4 months ago

People

(Reporter: itiel_yn8, Assigned: rrosario)

Tracking

({rtl})

unspecified
Firefox 67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 verified)

Details

Attachments

(1 attachment)

Reporter

Description

4 months ago

In RTL locales the Pin/Unpin icons should be mirrored.

I suppose the responsible code is around here:
https://searchfox.org/mozilla-central/source/browser/themes/shared/urlbar-searchbar.inc.css#163-172

Component: Activity Streams: Newtab → Theme
Priority: -- → P5
Reporter

Comment 1

4 months ago

Adding the following rule seems to fix it for me:

#pageAction-panel-pinTab:-moz-locale-dir(rtl) > .toolbarbutton-icon,
#pageAction-urlbar-pinTab:-moz-locale-dir(rtl),
#pageAction-panel-pinTab[pinned]:-moz-locale-dir(rtl) > .toolbarbutton-icon,
#pageAction-urlbar-pinTab[pinned]:-moz-locale-dir(rtl) {
  transform: scaleX(-1);
}

Maybe it's better to merge it with the sendToDevice rule?

(In reply to Itiel from comment #1)

Maybe it's better to merge it with the sendToDevice rule?

Yeah, probably. Thank you!

Assignee: nobody → rrosario

Comment 4

4 months ago
Pushed by rrosario@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b02d1b4938cc
[RTL] Mirror the Pin/Unpin icons on the Page Actions menu r=andreio

Comment 5

4 months ago
bugherder
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
Reporter

Comment 6

4 months ago

Looking good on latest Nightly. Thanks!

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.