1530735 - [RTL] Mirror the Pin/Unpin icons on the Page Actions menu

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P5)

Description

[Itiel]

In RTL locales the Pin/Unpin icons should be mirrored.

I suppose the responsible code is around here:
https://searchfox.org/mozilla-central/source/browser/themes/shared/urlbar-searchbar.inc.css#163-172

Comment 1

[Itiel]

Adding the following rule seems to fix it for me:

#pageAction-panel-pinTab:-moz-locale-dir(rtl) > .toolbarbutton-icon,
#pageAction-urlbar-pinTab:-moz-locale-dir(rtl),
#pageAction-panel-pinTab[pinned]:-moz-locale-dir(rtl) > .toolbarbutton-icon,
#pageAction-urlbar-pinTab[pinned]:-moz-locale-dir(rtl) {
  transform: scaleX(-1);
}

Maybe it's better to merge it with the sendToDevice rule?

Comment 2

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Itiel from comment #1)

Maybe it's better to merge it with the sendToDevice rule?

Yeah, probably. Thank you!

Comment 3

[Ricky Rosario [:rrosario, :r1cky]]

Attachment: Bug 1530735 - [RTL] Mirror the Pin/Unpin icons on the Page Actions menu

MozReview-Commit-ID: 2n6NXXweIfG

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b02d1b4938cc
[RTL] Mirror the Pin/Unpin icons on the Page Actions menu r=andreio

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/b02d1b4938cc

Comment 6

[Itiel]

Looking good on latest Nightly. Thanks!