Status

()

enhancement
P1
normal
VERIFIED FIXED
6 months ago
2 months ago

People

(Reporter: thecount, Assigned: nanj)

Tracking

({github-merged})

unspecified
Firefox 68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox66 wontfix, firefox67 wontfix, firefox68 verified)

Details

Attachments

(2 attachments)

With the new Discovery Stream, we now track visibility based on if the element has been scrolled to, not based on if the page has loaded it.

We can track both. Some sort of event that says what is loaded, and then we can compare that to what is seen.

Blocks: 1530746

[Tracking Requested - why for this release]: important new telemetry for Pocket experiment

Assignee: nobody → najiang
Iteration: --- → 67.3 - Feb 25 - Mar 10
Priority: -- → P1
Iteration: 67.3 - Feb 25 - Mar 10 → 68.1 - Mar 18 - 31
Severity: normal → enhancement
No longer blocks: 1512725

We're going to add a new ping - "loaded" for each component (hero, list, and cardgrid) structured as:

{
"source": ["HERO" | "LIST" | "CARDGRID"], // any one of them
"loaded": 3, // size of "tiles" array
"tiles": [{id: 1, pos: 0}, {id: 2, pos: 1}, {id: 3, pos: 2}]
}

This requires some server side changes to:

  • Add a new column "loaded" to the impression table
  • Process this event in the impression_stats ETL job
Iteration: 68.1 - Mar 18 - 31 → 68.2 - Apr 1 - 14
Attachment #9055210 - Flags: data-review?(kenny)
Comment on attachment 9055210 [details]
data_review_request_loaded_content.txt

data-review+

1) Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes: https://github.com/mozilla/activity-stream/pull/4868/files#diff-f9d20d6688eef2754298456e5d5b836b

2) Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, the user can opt-out the data collection by either disabling the telemetry of Activity Stream or disabling the Firefox telemetry as a whole.

3) If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes. Kirill Demtchouk and Nan Jiang will be monitoring these metrics.

4) Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2

5) Is the data collection request for default-on or default-off?

Default-on

6) Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No, all identifiers used are pre-existing.

7) Is the data collection covered by the existing Firefox privacy notice?

Yes

8) Does there need to be a check-in in the future to determine whether to renew the data?

No

9) Does the data collection use a third-party collection tool?

No
Attachment #9055210 - Flags: data-review?(kenny) → data-review+
Blocks: 1543756
Status: NEW → RESOLVED
Closed: 4 months ago
Keywords: github-merged
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68

I have verified this issue with the latest Firefox Nightly (68.0a1 Build ID - 20190414214746) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3. Now, three pings are displayed in the browser console after the tab is closed. You can find an example below:

TELEMETRY PING: {"locale":"en-US","topic":"activity-stream","client_id":"n/a","version":"68.0a1","release_channel":"nightly","addon_version":"20190414214746","user_prefs":255,"session_id":"n/a","page":"about:newtab","source":"CARDGRID","tiles":[{"id":37053,"pos":0},{"id":37064,"pos":1},{"id":36415,"pos":2}],"loaded":3,"action":"activity_stream_impression_stats","impression_id":"{1e7b26af-5d7f-4fec-87fe-fa0a4eeebd74}","profile_creation_date":18001,"region":"US"}

TELEMETRY PING: {"locale":"en-US","topic":"activity-stream","client_id":"n/a","version":"68.0a1","release_channel":"nightly","addon_version":"20190414214746","user_prefs":255,"session_id":"n/a","page":"about:newtab","source":"CARDGRID","tiles":[{"id":36415,"pos":2},{"id":37064,"pos":1},{"id":37053,"pos":0}],"action":"activity_stream_impression_stats","impression_id":"{1e7b26af-5d7f-4fec-87fe-fa0a4eeebd74}","profile_creation_date":18001,"region":"US"}

TELEMETRY PING: {"locale":"en-US","topic":"activity-stream","client_id":"5c0c8013-fa8e-43ab-8739-07ba624b7037","version":"68.0a1","release_channel":"nightly","addon_version":"20190414214746","user_prefs":255,"session_id":"{fb10286e-d6f5-4050-93fd-5da1e8d10b5a}","page":"about:newtab","session_duration":1131,"action":"activity_stream_session","perf":{"load_trigger_type":"menu_plus_or_keyboard","is_preloaded":true,"is_prerendered":false,"topsites_icon_stats":{"custom_screenshot":0,"screenshot_with_icon":0,"screenshot":0,"tippytop":6,"rich_icon":0,"no_image":0},"topsites_pinned":1,"topsites_search_shortcuts":1,"topsites_first_painted_ts":1555329958902,"load_trigger_ts":1555333257083,"visibility_event_rcvd_ts":1555333257072},"profile_creation_date":18001,"region":"US"}

Status: RESOLVED → VERIFIED
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.