Closed Bug 1530741 Opened 8 months ago Closed 8 months ago

test262 import-script alterations

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: Waldo, Assigned: Waldo)

Details

Attachments

(2 files)

We haven't imported test262 tests in three months, and it kind of shows. Everything going to seed.

It's not a forcible source-hook to allow only test262 updates to touch these files, but it's better than nothing.
Attachment #9046760 - Flags: review?(jorendorff)
Comment on attachment 9046760 [details] [diff] [review]
Add a // GENERATED, DO NOT EDIT comment to the top of every non-empty shell.js generated by importing test262 tests

Review of attachment 9046760 [details] [diff] [review]:
-----------------------------------------------------------------

I don't understand why js/src/tests/test262/built-ins/JSON/stringify/bigint-tojson-receiver.js was deleted in this changeset. Apart from that, r=me.
Attachment #9046760 - Flags: review?(jorendorff) → review+
Comment on attachment 9046759 [details] [diff] [review]
Make running the test262 import script with the current imported revision a no-op again

Review of attachment 9046759 [details] [diff] [review]:
-----------------------------------------------------------------

Jeff clarified on IRC what's going on here:

1. Bug 1517868 added a few lines to a shell.js file that is autogenerated. This patch "upstreams" those three lines to the source file.

2. It's unclear what caused the `git` output stored in GIT-INFO to change, but according to Waldo it doesn't matter because nobody uses it. Anyway the goal with this patch is just to make the file agree with the *current* output of the import script, and the current script emits a `Merge` line.
Attachment #9046759 - Flags: review?(jorendorff) → review+
Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5f4cc2c45517
Make running the test262 import script with the current imported revision a no-op again (up to a single test added locally, that still hasn't been imported from upstream).  r=jorendorff
https://hg.mozilla.org/integration/mozilla-inbound/rev/daf5c6e6275a
Add a // GENERATED, DO NOT EDIT comment to the top of every non-empty shell.js generated by importing test262 tests.  r=jorendorff
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.