Closed Bug 1530757 Opened 5 years ago Closed 5 years ago

Confirm that GV 68 Nightly's crash reporter is working in Focus 8.0

Categories

(GeckoView :: General, task, P1)

All
Android

Tracking

(firefox66 unaffected, firefox67 unaffected, firefox68 verified)

RESOLVED FIXED
Tracking Status
firefox66 --- unaffected
firefox67 --- unaffected
firefox68 --- verified

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

(Whiteboard: [geckoview:fenix:m4])

I see recent Sentry crash reports from 8.0.8 [1]:

https://sentry.prod.mozaws.net/operations/focus-android/releases/

But I see exactly 0 GV crash reports from GV 65 and 100+ crash reports from GV 64 (users who presumably should have been updated to Focus 8.0 with GV 65):

https://crash-stats.mozilla.com/search/?product=focus&date=%3E%3D2019-02-19T18%3A28%3A00.000Z&date=%3C2019-02-26T18%3A28%3A00.000Z&_facets=signature&_facets=version&_facets=cpu_arch&_sort=-date&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#facet-version

OTOH, my Focus 8.0.8 has GV 65, so either GV 65 is crash-free or there is a problem with our crash reporter.

Even though this is a Focus issue, I'm adding the [geckoview:fenix:m2] whiteboard tag because Fenix is relying on Focus to get beta testing of GV until we have more Fenix beta testers.

Whiteboard: [geckoview:fenix:m2]

I tried 'about:crashparent' in Focus and got the following when trying to report the crash. Looks like a mismatch between a-c and GeckoView.

02-26 13:20:00.850 31121 31150 E AndroidRuntime: Process: org.mozilla.focus:mozilla.components.lib.crash.CrashReporter, PID: 31121
02-26 13:20:00.850 31121 31150 E AndroidRuntime: java.lang.NoSuchMethodError: No static method sendCrashReport(Landroid/content/Context;Ljava/io/File;Ljava/io/File;ZLjava/lang/String;)V in class Lorg/mozilla/geckoview/CrashReporter; or its super classes (declaration of 'org.mozilla.geckoview.CrashReporter' appears in base.apk)
02-26 13:20:00.850 31121 31150 E AndroidRuntime: at mozilla.components.lib.crash.service.MozillaSocorroService.sendViaGeckoViewCrashReporter$lib_crash_release(MozillaSocorroService.kt:42)
02-26 13:20:00.850 31121 31150 E AndroidRuntime: at mozilla.components.lib.crash.service.MozillaSocorroService.report(MozillaSocorroService.kt:38)
02-26 13:20:00.850 31121 31150 E AndroidRuntime: at mozilla.components.lib.crash.CrashReporter.submitReport(CrashReporter.kt:79)
02-26 13:20:00.850 31121 31150 E AndroidRuntime: at mozilla.components.lib.crash.prompt.CrashReporterActivity$sendCrashReportIfNeeded$1.invokeSuspend(CrashReporterActivity.kt:92)
02-26 13:20:00.850 31121 31150 E AndroidRuntime: at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:32)
02-26 13:20:00.850 31121 31150 E AndroidRuntime: at kotlinx.coroutines.DispatchedTask.run(Dispatched.kt:236)
02-26 13:20:00.850 31121 31150 E AndroidRuntime: at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:594)
02-26 13:20:00.850 31121 31150 E AndroidRuntime: at kotlinx.coroutines.scheduling.CoroutineScheduler.access$runSafely(CoroutineScheduler.kt:60)
02-26 13:20:00.850 31121 31150 E AndroidRuntime: at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:742)
02-26 13:20:00.850 31121 31150 I mozac/CrashReporter: Received crash: UncaughtExceptionCrash(throwable=java.lang.NoSuchMethodError: No static method sendCrashReport(Landroid/content/Context;Ljava/io/File;Ljava/io/File;ZLjava/lang/String;)V in class Lorg/mozilla/geckoview/CrashReporter; or its super classes (declaration of 'org.mozilla.geckoview.CrashReporter' appears in base.apk))

Dylan said he will fix this bug. He says the problem is the Focus 8.0 is using a version of A-C that is not API compatible with GV 65.

Nick says fat AARs (bug 1508976 and bug 1522581) will fix avoid dependency problems like this.

Assignee: nobody → droeh
See Also: → 1508976, 1522581
Blocks: 1531858

Dylan's new plan is to skip GV 65 and update Focus 8.0 to GV 67 Beta (bug 1531858). Assigning this bug to myself as a reminder to verify that GV 67's crash reporter is successfully submitting Focus crash reports to Socorro.

Assignee: droeh → cpeterson
No longer blocks: 1531858
Depends on: 1531858
Summary: Why are there no crash reports for GV 65 in Focus 8.0.x? → Confirm that GV 67 crash reporter is working in Focus 8.0
Whiteboard: [geckoview:fenix:m2] → [geckoview:fenix:m3]

Deferring to [geckoview:fenix:m4] because Dylan is going on PTO for two weeks and Vesta says updating Focus can wait until April.

Whiteboard: [geckoview:fenix:m3] → [geckoview:fenix:m4]
Summary: Confirm that GV 67 crash reporter is working in Focus 8.0 → Confirm that GV 68 Nightly's crash reporter is working in Focus 8.0

Yep! We're getting Socorro crash reports for GV 68 in Focus 8.0.9:

https://crash-stats.mozilla.com/topcrashers/?product=Focus&version=68.0a1

Status: NEW → RESOLVED
Type: defect → task
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.