Closed Bug 1530767 Opened 2 years ago Closed 2 years ago

Don't limit bug 1529380 to the handoff-to-awesomebar flow

Categories

(Firefox :: Search, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 67
Tracking Status
firefox67 --- fixed

People

(Reporter: Felipe, Assigned: Felipe)

References

Details

(Whiteboard: [fxperf:p1])

Attachments

(1 file)

In bug 1529380 I had added a limitation to the improvements there to the handoff-to-awesomebar flow, because I thought that the .icos didn't work with the <img> tags from the previous UI (the in-page search one-off buttons).

But it turns out this was just because of a missing contentaccessible=yes. So we can just add it and remove that limitation.

Will the icons for plugins added by webextensions be contentaccessible too? Or are we sure they are always data: uris?

(In reply to Florian Quèze [:florian] from comment #2)

Will the icons for plugins added by webextensions be contentaccessible too?
Or are we sure they are always data: uris?

They will never be data: uris (see bug 1530027 comment 2). Dale is trying to use the webextensions version of contentaccessible. It's not working but that's probably story for the bugs where he's doing that work.

Pushed by fgomes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/759ec998fe87
Don't limit bug 1529380 improvements to the handoff-to-awesomebar flow. r=mconley
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.