1530771 - Inconsistency between "& (ampersand) vs "and" in Options

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P5)

Description

[PikeUK]

Apologies if this it too nitpicky/timewasting.

Some headings/labels in Options join two words with "and" but some join them with "&" (ampersand), this happens in both en-US and en-GB.

"and":
Language and Appearance
Files and Applications
New Windows and Tabs
Homepage and new windows
Cookies and Site Data
Deceptive Content and Dangerous Software Protection

"&":
Fonts & Colours
Privacy & Security
Logins & Passwords
Extensions & Themes

Note: There's also disagreement regarding the Oxford comma, some labels use it, some don't.

Tested on Fx66b11 on Windows 10 v1809.

Comment 1

[Sam Foster [:sfoster] (he/him)]

Michelle, is this something we should plan to fix?

Comment 2

[mheubusch]

Thanks @PikeUK - not too picky at all. I appreciate the careful review and attention to details we should have caught sooner.

@Sam - it's not a high priority but please fix if/when possible.

The only place we should use the & ampersand is in navigation menus where space is limited. Privacy & Security is the only instance in Prefs/Options where this should happen. We also use the series (aka Oxford) comma.

on about:preferences#general

please use "Fonts and Colors"

on about:preferences#privacy

add a comma after data in "Your stored cookies, site data, and cache are currently "

use "Logins and Passwords"
use "Forms and Autofill"

add a comma after form in "Nightly will remember your browsing, download, form and search history."

Comment 3

[Sam Foster [:sfoster] (he/him)]

Flagging this as a mentored, good-first-bug. You will need the ability to build an english language (en-US) Firefox. Locate the strings in the UI and change the corresponding string files in the codebase. You can use an artifact build[1] to confirm the changes have the expected effect in the UI. We have guidelines on the best practices for updating existing strings at [2].

Let me know if you want to work on this and I can help you get set up.

1. https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Artifact_builds
2. https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Changing_existing_strings

Comment 4

[Mauricio Araujo]

Hi! I am an Outreachy applicant and I'd like to work on this issue. Any suggestions on where to start?

Comment 5

[Shivam Singhal [ :championshuttler ]]

Hi @Mauricio Are you working on it? If not can i take this up. I build the Firefox locally.

Thanks

Comment 6

[Mauricio Araujo]

Yes, I am working on it. I was waiting to be assigned in order to submit my progress and get my code reviewed.

Comment 7

[Sam Foster [:sfoster] (he/him)]

(In reply to Mauricio Araujo from comment #6)

Yes, I am working on it. I was waiting to be assigned in order to submit my progress and get my code reviewed.

Hi Mauricio, thanks for picking this up. I've assigned this to you. Let me know here or in IRC (#fx-team) if you have any questions about setting your development environment [1], or this issue in particular.

When you have a patch ready, you'll use moz-phab to submit it for review. I'll do the initial review but we'll need r+ from :jaws before landing.

1. https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction

Comment 8

[Sam Foster [:sfoster] (he/him)]

(In reply to Mauricio Araujo from comment #4)

Hi! I am an Outreachy applicant and I'd like to work on this issue. Any suggestions on where to start?

I suggest starting by searching at http://searchfox.org/ for each of the strings in comment #0. That will get you the files you need to change. I think most (all?) should be fluent (.ftl) files at this point, but there could be some .properties and dtds.

You'll also need to figure out where in the UI those strings appears. Usually, once you have the string id you can search for instances of that and narrow down where you should be looking.

Comment 9

[Mauricio Araujo]

Attachment: Inconsistency between "&" (ampersand) vs "and" in Options (Bug 1530771)

Replaced instances where "&" (ampersand) was used instead of "and" to join two words in the preferences menu, and added Oxford comma where appropiate in certain
labels to ensure consistency.

Comment 10

[Mauricio Araujo]

(In reply to Sam Foster [:sfoster] (he/him) from comment #7)

When you have a patch ready, you'll use moz-phab to submit it for review. I'll do the initial review but we'll need r+ from :jaws before landing.

I replaced all strings mentioned in comment #0 and submitted my patch. Please tell me if there is anything else I need to do. Thank you for the assistance.

Comment 11

[Sam Foster [:sfoster] (he/him)]

:flod, looks like this patch needs your actual r+ to land?

Comment 12

[Francesco Lodolo [:flod]]

(In reply to Sam Foster [:sfoster] (he/him) from comment #11)

:flod, looks like this patch needs your actual r+ to land?

Please use blocking reviewers in Phabricator for this (I see jaws was already on it) ;-)

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7cd2f1e7f66
Inconsistency between "&" (ampersand) vs "and" in Options r=jaws,flod

Comment 14

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e7cd2f1e7f66