Closed Bug 1530777 Opened 2 years ago Closed 2 years ago

Replace waitForCondition in browser_884402_customize_from_overflow.js withTestUtils.waitForCondition

Categories

(Firefox :: Toolbars and Customization, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 67
Tracking Status
firefox67 --- fixed

People

(Reporter: johannh, Assigned: lloanalas, Mentored)

References

Details

(Keywords: good-first-bug)

Attachments

(1 file, 1 obsolete file)

This is a good first bug for newcomers to Firefox development.

waitForCondition usage in the browser_884402_customize_from_overflow.js test file can be replaced by the TestUtils.waitForCondition utility function.

The code in question is here: https://searchfox.org/mozilla-central/rev/dbddac86aadf1d4871fb350bbe66db43728a9f81/browser/components/customizableui/test/browser_884402_customize_from_overflow.js#21,64

There are multiple occurrences that need to be replaced.

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://developer.mozilla.org/en-US/docs/Introduction.

You can run this test with the ./mach mochitest command:

./mach mochitest browser/components/customizableui/test/browser_884402_customize_from_overflow.js

Please leave a comment if you would like to be assigned to this bug and feel free to ask questions here or via IRC if you're stuck.

Hi, I'd like to take a stab at this bug. Could this be assigned to me?

Thanks!

Yup, thank you!

Assignee: nobody → lloanalas
Status: NEW → ASSIGNED

Replacing waitForCondition function with TestUtils.waitForCondition() function.

(In reply to Johann Hofmann [:johannh] from comment #2)

Yup, thank you!

Johann,

I think I pushed a commit - could you take a look at how it's formatted? Not sure if I did it right. I'm used to using Git and a few things are quite different between Git and Mercurial.

Thanks!

Replacing waitForCondition function with TestUtils.waitForCondition() function.

Replaced waitForCondition with TestUtils.waitForCondition - 3 instances for bug 1530783

Comment on attachment 9046894 [details]
Replaced waitForCondition with TestUtils.waitForCondition for bug 1530777

Revision D21296 was moved to bug 1530783. Setting attachment 9046894 [details] to obsolete.

Attachment #9046894 - Attachment is obsolete: true
Attachment #9046863 - Attachment description: Replaced waitForCondition with TestUtils.waitForCondition for bug 1530777 → Bug 1530777 - Replace waitForCondition with TestUtils.waitForCondition. r=johannh
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/46950990b58a
Replace waitForCondition with TestUtils.waitForCondition. r=johannh
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.