Closed Bug 1530778 Opened 9 months ago Closed 9 months ago

Replace waitForCondition in browser_885052_customize_mode_observers_disabed.js withTestUtils.waitForCondition

Categories

(Firefox :: Toolbars and Customization, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 67
Tracking Status
firefox67 --- fixed

People

(Reporter: johannh, Assigned: aiyemacbain, Mentored)

References

Details

(Keywords: good-first-bug)

Attachments

(1 file)

This is a good first bug for newcomers to Firefox development.

waitForCondition usage in the browser_885052_customize_mode_observers_disabed.js test file can be replaced by the TestUtils.waitForCondition utility function.

The code in question is here: https://searchfox.org/mozilla-central/rev/dbddac86aadf1d4871fb350bbe66db43728a9f81/browser/components/customizableui/test/browser_885052_customize_mode_observers_disabed.js#29,44

There are multiple occurrences that need to be replaced.

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://developer.mozilla.org/en-US/docs/Introduction.

You can run this test with the ./mach mochitest command:

./mach mochitest browser/components/customizableui/test/browser_885052_customize_mode_observers_disabed.js

Please leave a comment if you would like to be assigned to this bug and feel free to ask questions here or via IRC if you're stuck.

I would like to be assigned this bug. I am an Outreachy applicant.

I'd like to work on this bug.

aiyemacbain was first to ask, so, there you go!

Assignee: nobody → aiyemacbain
Status: NEW → ASSIGNED

Setting checkin-needed to get this landed for us!

Keywords: checkin-needed

Pushed by dluca@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2e89b1f1e01c
Replace waitForCondition in browser_88502_customize_mode_observers_disabed.js with TestUtils.waitForCondition. r=johannh

Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67

Hello @johann can I be assigned this bug?? I am an outreachy applicant.

You need to log in before you can comment on or make changes to this bug.