1530778 - Replace waitForCondition in browser_885052_customize_mode_observers_disabed.js withTestUtils.waitForCondition

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, enhancement, P5)

Description

[Johann Hofmann [:johannh]]

This is a good first bug for newcomers to Firefox development.

waitForCondition usage in the browser_885052_customize_mode_observers_disabed.js test file can be replaced by the TestUtils.waitForCondition utility function.

The code in question is here: https://searchfox.org/mozilla-central/rev/dbddac86aadf1d4871fb350bbe66db43728a9f81/browser/components/customizableui/test/browser_885052_customize_mode_observers_disabed.js#29,44

There are multiple occurrences that need to be replaced.

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://developer.mozilla.org/en-US/docs/Introduction.

You can run this test with the ./mach mochitest command:

./mach mochitest browser/components/customizableui/test/browser_885052_customize_mode_observers_disabed.js

Please leave a comment if you would like to be assigned to this bug and feel free to ask questions here or via IRC if you're stuck.

Comment 1

[aiyemacbain]

I would like to be assigned this bug. I am an Outreachy applicant.

Comment 2

[Pavithra]

I'd like to work on this bug.

Comment 3

[Johann Hofmann [:johannh]]

aiyemacbain was first to ask, so, there you go!

Comment 4

[aiyemacbain]

Attachment: Bug 1530778 - Replace waitForCondition in browser_88502_customize_mode_observers_disabed.js with TestUtils.waitForCondition. r=johannh

Comment 5

[Johann Hofmann [:johannh]]

Setting checkin-needed to get this landed for us!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e89b1f1e01c
Replace waitForCondition in browser_88502_customize_mode_observers_disabed.js with TestUtils.waitForCondition. r=johannh

Comment 7

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/2e89b1f1e01c

Comment 8

[afshan.shokath]

Hello @johann can I be assigned this bug?? I am an outreachy applicant.