Replace waitForCondition in browser_909779_overflow_toolbars_new_window.js withTestUtils.waitForCondition

RESOLVED FIXED in Firefox 67

Status

()

enhancement
P5
normal
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: johannh, Assigned: lloanalas, Mentored)

Tracking

(Blocks 1 bug, {good-first-bug})

unspecified
Firefox 67
Points:
---

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 months ago

This is a good first bug for newcomers to Firefox development.

waitForCondition usage in the browser_909779_overflow_toolbars_new_window.js test file can be replaced by the TestUtils.waitForCondition utility function.

The code in question is here: https://searchfox.org/mozilla-central/rev/dbddac86aadf1d4871fb350bbe66db43728a9f81/browser/components/customizableui/test/browser_909779_overflow_toolbars_new_window.js#14,20,25

There are multiple occurrences that need to be replaced.

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://developer.mozilla.org/en-US/docs/Introduction.

You can run this test with the ./mach mochitest command:

./mach mochitest browser/components/customizableui/test/browser_909779_overflow_toolbars_new_window.js

Please leave a comment if you would like to be assigned to this bug and feel free to ask questions here or via IRC if you're stuck.

(Assignee)

Comment 1

3 months ago

Hi,

If no one has claimed this one, it would be great to have another bug to try and figure out how to reset my repo version and work on a new bug.

Comment 2

3 months ago

Hi! I am an Outreachy applicant and I'd like to work on this bug.

(Assignee)

Comment 3

3 months ago

Replaced waitForCondition with TestUtils.waitForCondition - 3 instances for bug 1530783

(Assignee)

Comment 4

3 months ago

Johann,

Trying to figure out how mercurial works as I come from using Git. Trying to reset my local version to the latest version and having a nice time figuring that out. You can see that my previous commit to another bug was added with the commit for this one. What is the usual workflow - in Git we would create a new branch and work on our bug - but how does that work here?

Comment 5

3 months ago

Hi Johann,

I am an Outreachy applicant. Can I work on this issue ?

Flags: needinfo?(jhofmann)
(Assignee)

Comment 6

3 months ago

Hi Tuhina,

I'm also an Outreachy applicant. I asked to work on this bug earlier today and submitted a bugfix for revision, thought I'd point that out just in case. (In reply to tuhina chatterjee from comment #5)

Hi Johann,

I am an Outreachy applicant. Can I work on this issue ?

(Reporter)

Comment 7

3 months ago

Yeah, sorry, lloanalas should be assigned to this.

Assignee: nobody → lloanalas
Status: NEW → ASSIGNED
Flags: needinfo?(jhofmann)
Attachment #9046899 - Attachment description: Replaced waitForCondition with TestUtils.waitForCondition for bug 1530783 → Bug 1530783 - Replace waitForCondition with TestUtils.waitForCondition. r=johannh
(Reporter)

Comment 8

3 months ago

Setting checkin-needed to get this landed...

Keywords: checkin-needed

Comment 9

3 months ago

Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7b207f663111
Replace waitForCondition with TestUtils.waitForCondition. r=johannh

Keywords: checkin-needed

Comment 10

3 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.