1530783 - Replace waitForCondition in browser_909779_overflow_toolbars_new_window.js withTestUtils.waitForCondition

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, enhancement, P5)

Description

[Johann Hofmann [:johannh]]

This is a good first bug for newcomers to Firefox development.

waitForCondition usage in the browser_909779_overflow_toolbars_new_window.js test file can be replaced by the TestUtils.waitForCondition utility function.

The code in question is here: https://searchfox.org/mozilla-central/rev/dbddac86aadf1d4871fb350bbe66db43728a9f81/browser/components/customizableui/test/browser_909779_overflow_toolbars_new_window.js#14,20,25

There are multiple occurrences that need to be replaced.

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://developer.mozilla.org/en-US/docs/Introduction.

You can run this test with the ./mach mochitest command:

./mach mochitest browser/components/customizableui/test/browser_909779_overflow_toolbars_new_window.js

Please leave a comment if you would like to be assigned to this bug and feel free to ask questions here or via IRC if you're stuck.

Comment 1

[lloan alas:[lloanalas]]

Hi,

If no one has claimed this one, it would be great to have another bug to try and figure out how to reset my repo version and work on a new bug.

Comment 2

[Mauricio Araujo]

Hi! I am an Outreachy applicant and I'd like to work on this bug.

Comment 3

[lloan alas:[lloanalas]]

Attachment: Bug 1530783 - Replace waitForCondition with TestUtils.waitForCondition. r=johannh

Replaced waitForCondition with TestUtils.waitForCondition - 3 instances for bug 1530783

Comment 4

[lloan alas:[lloanalas]]

Johann,

Trying to figure out how mercurial works as I come from using Git. Trying to reset my local version to the latest version and having a nice time figuring that out. You can see that my previous commit to another bug was added with the commit for this one. What is the usual workflow - in Git we would create a new branch and work on our bug - but how does that work here?

Comment 5

[tuhina chatterjee]

Hi Johann,

I am an Outreachy applicant. Can I work on this issue ?

Comment 6

[lloan alas:[lloanalas]]

Hi Tuhina,

I'm also an Outreachy applicant. I asked to work on this bug earlier today and submitted a bugfix for revision, thought I'd point that out just in case. (In reply to tuhina chatterjee from comment #5)

Hi Johann,

I am an Outreachy applicant. Can I work on this issue ?

Comment 7

[Johann Hofmann [:johannh]]

Yeah, sorry, lloanalas should be assigned to this.

Comment 8

[Johann Hofmann [:johannh]]

Setting checkin-needed to get this landed...

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b207f663111
Replace waitForCondition with TestUtils.waitForCondition. r=johannh

Comment 10

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/7b207f663111