Replace waitForCondition in browser_940307_panel_click_closure_handling.js withTestUtils.waitForCondition

RESOLVED FIXED in Firefox 67

Status

()

enhancement
P5
normal
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: johannh, Assigned: mscs.kim, Mentored)

Tracking

({good-first-bug})

unspecified
Firefox 67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

This is a good first bug for newcomers to Firefox development.

waitForCondition usage in the browser_940307_panel_click_closure_handling.js test file can be replaced by the TestUtils.waitForCondition utility function.

The code in question is here: https://searchfox.org/mozilla-central/rev/dbddac86aadf1d4871fb350bbe66db43728a9f81/browser/components/customizableui/test/browser_940307_panel_click_closure_handling.js#35

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://developer.mozilla.org/en-US/docs/Introduction.

You can run this test with the ./mach mochitest command:

./mach mochitest browser/components/customizableui/test/browser_940307_panel_click_closure_handling.js

Please leave a comment if you would like to be assigned to this bug and feel free to ask questions here or via IRC if you're stuck.

Assignee

Comment 1

4 months ago

Hi, I'm new to the community and would like to be assigned to the issue.

Of course, let me know if you need any help!

Assignee: nobody → mscs.kim
Status: NEW → ASSIGNED

Let's get this checked in!

Keywords: checkin-needed

Comment 5

4 months ago

Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/f1dd1d737828
Replaced waitForCondition function with TestUtils.waitForCondition r=johannh

Keywords: checkin-needed

Comment 6

4 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.