Closed Bug 1530799 Opened 2 years ago Closed 1 year ago

Replace waitForCondition in browser_940307_panel_click_closure_handling.js withTestUtils.waitForCondition

Categories

(Firefox :: Toolbars and Customization, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 67
Tracking Status
firefox67 --- fixed

People

(Reporter: johannh, Assigned: mscs.kim, Mentored)

References

Details

(Keywords: good-first-bug)

Attachments

(1 file)

This is a good first bug for newcomers to Firefox development.

waitForCondition usage in the browser_940307_panel_click_closure_handling.js test file can be replaced by the TestUtils.waitForCondition utility function.

The code in question is here: https://searchfox.org/mozilla-central/rev/dbddac86aadf1d4871fb350bbe66db43728a9f81/browser/components/customizableui/test/browser_940307_panel_click_closure_handling.js#35

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://developer.mozilla.org/en-US/docs/Introduction.

You can run this test with the ./mach mochitest command:

./mach mochitest browser/components/customizableui/test/browser_940307_panel_click_closure_handling.js

Please leave a comment if you would like to be assigned to this bug and feel free to ask questions here or via IRC if you're stuck.

Hi, I'm new to the community and would like to be assigned to the issue.

Of course, let me know if you need any help!

Assignee: nobody → mscs.kim
Status: NEW → ASSIGNED

Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/f1dd1d737828
Replaced waitForCondition function with TestUtils.waitForCondition r=johannh

Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.