1530799 - Replace waitForCondition in browser_940307_panel_click_closure_handling.js withTestUtils.waitForCondition

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, enhancement, P5)

Description

[Johann Hofmann [:johannh]]

This is a good first bug for newcomers to Firefox development.

waitForCondition usage in the browser_940307_panel_click_closure_handling.js test file can be replaced by the TestUtils.waitForCondition utility function.

The code in question is here: https://searchfox.org/mozilla-central/rev/dbddac86aadf1d4871fb350bbe66db43728a9f81/browser/components/customizableui/test/browser_940307_panel_click_closure_handling.js#35

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://developer.mozilla.org/en-US/docs/Introduction.

You can run this test with the ./mach mochitest command:

./mach mochitest browser/components/customizableui/test/browser_940307_panel_click_closure_handling.js

Please leave a comment if you would like to be assigned to this bug and feel free to ask questions here or via IRC if you're stuck.

Comment 1

[mscs.kim]

Hi, I'm new to the community and would like to be assigned to the issue.

Comment 2

[Johann Hofmann [:johannh]]

Of course, let me know if you need any help!

Comment 3

[mscs.kim]

Attachment: Bug 1530799 - Replaced waitForCondition function with TestUtils.waitForCondition r=johannh

Comment 4

[Johann Hofmann [:johannh]]

Let's get this checked in!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f1dd1d737828
Replaced waitForCondition function with TestUtils.waitForCondition r=johannh

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f1dd1d737828