Closed Bug 1530801 Opened 7 months ago Closed 7 months ago

Replace waitForCondition in browser_947914_button_addons.js withTestUtils.waitForCondition

Categories

(Firefox :: Toolbars and Customization, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 67
Tracking Status
firefox67 --- fixed

People

(Reporter: johannh, Assigned: pong7219, Mentored)

References

Details

(Keywords: good-first-bug)

Attachments

(1 file)

This is a good first bug for newcomers to Firefox development.

waitForCondition usage in the browser_947914_button_addons.js test file can be replaced by the TestUtils.waitForCondition utility function.

The code in question is here: https://searchfox.org/mozilla-central/rev/dbddac86aadf1d4871fb350bbe66db43728a9f81/browser/components/customizableui/test/browser_947914_button_addons.js#24

There are multiple occurrences that need to be replaced.

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://developer.mozilla.org/en-US/docs/Introduction.

You can run this test with the ./mach mochitest command:

./mach mochitest browser/components/customizableui/test/browser_947914_button_addons.js

Please leave a comment if you would like to be assigned to this bug and feel free to ask questions here or via IRC if you're stuck.

Hi [:Johannh],
I would like to take this task. Could you assign it to me, please?
Thanks!

Yup, have fun!

Assignee: nobody → pong7219
Status: NEW → ASSIGNED

(In reply to Mellina Y. from comment #1)

Hi [:Johannh],
I would like to take this task. Could you assign it to me, please?
Thanks!

hi Mellina, are you still working in this bug? cause if not, I could take it up.

(In reply to ekikoh from comment #3)

(In reply to Mellina Y. from comment #1)

Hi [:Johannh],
I would like to take this task. Could you assign it to me, please?
Thanks!

hi Mellina, are you still working in this bug? cause if not, I could take it up.

Hi ekikoh, I'm still working on it and will have an update today.
I'll let you know if I'm not able to complete this.

Thanks!

waitForCondition usage in the browser_947914_button_addons.js test file can be replaced by the TestUtils.waitForCondition utility function.

The function was replaced. There was only one occurance in this file (browser_947914_button_addons.js), but may exists in other ones.

Johann, I have changed the function and tested via mochitest.
I didn't find any other waitForCondition functions in the browser_947914_button_addons.js file, but there is certainly in other files.

If this bug is incomplete, please let me know.

P.S.: this is my first time sending a patch here, so I might have messed up something. Please let me know if that happened!!

Let's get this checked in...

Keywords: checkin-needed

Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c6d34d35ff2e
Replace waitForCondition in browser_947914_button_addons.js withTestUtils.waitForCondition r=johannh

Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.